cd0b413706
Moves everything Camera related into `core/` / `Core/` so that it is better encapsulated from React Native.
Benefits:
1. Code is much better organized. Should be easier for collaborators now, and cleaner codebase for me.
2. Locking is fully atomically as you can now only configure the session through a lock/Mutex which is batch-overridable
* On iOS, this makes Camera startup time **MUCH** faster, I measured speedups from **1.5 seconds** to only **240 milliseconds** since we only lock/commit once! 🚀
* On Android, this fixes a few out-of-sync/concurrency issues like "Capture Request contains unconfigured Input/Output Surface!" since it is now a single lock-operation! 💪
3. It is easier to integrate VisionCamera outside of React Native (e.g. Native iOS Apps, NativeScript, Flutter, etc)
With this PR, VisionCamera V3 is up to **7x** faster than V2
|
||
|---|---|---|
| .. | ||
| Core | ||
| Extensions | ||
| Frame Processor | ||
| Parsers | ||
| React Utils | ||
| Types | ||
| VisionCamera.xcodeproj | ||
| .swift-version | ||
| .swiftformat | ||
| .swiftlint.yml | ||
| CameraBridge.h | ||
| CameraDevicesManager.m | ||
| CameraDevicesManager.swift | ||
| CameraView.swift | ||
| CameraView+Focus.swift | ||
| CameraView+RecordVideo.swift | ||
| CameraView+TakePhoto.swift | ||
| CameraView+Zoom.swift | ||
| CameraViewManager.m | ||
| CameraViewManager.swift | ||
| README.md | ||
ios
This folder contains the iOS-platform-specific code for react-native-vision-camera.
Prerequesites
- Install Xcode tools
xcode-select --install - Install need SwiftFormat and SwiftLint
brew install swiftformat swiftlint
Getting Started
It is recommended that you work on the code using the Example project (example/ios/VisionCameraExample.xcworkspace), since that always includes the React Native header files, plus you can easily test changes that way.
You can however still edit the library project here by opening VisionCamera.xcodeproj, this has the advantage of automatically formatting your Code (swiftformat) and showing you Linter errors (swiftlint) when trying to build (⌘+B).
Committing
Before committing, make sure that you're not violating the Swift or C++ codestyles. To do that, run the following command:
yarn check-ios
This will also try to automatically fix any errors by re-formatting the Swift code.