Hampton Maxwell
02851bb21f
Display a warning when source is empty instead of throwing an error
2019-02-18 21:36:17 -08:00
Hampton Maxwell
f69231fe81
Merge pull request #1246 from niklassaers/master
...
Instead of crashing, show a warning and return
2019-02-18 21:34:46 -08:00
Hampton Maxwell
075dfbaf7f
Only check for an empty source
2019-02-18 21:34:34 -08:00
Hampton Maxwell
98eb7a3137
Merge pull request #1478 from laurent22/master
...
Throw an error instead of crashing app when video source is empty
2019-02-18 21:27:40 -08:00
Nick
b448b30de6
fix: remove runtime warning by replacing UIManager.RCTVideo with UIManager.getViewManagerConfig('RCTVideo') (and ensuring backwards compat) ( #1487 )
...
* replaced UIManager.RCTVideo > UIManager.getViewManagerConfig('RCTVideo')
* added requested changes
* updated changelog.md
* docs: adjust wording
2019-02-18 12:17:20 +01:00
Laurin Quast
d8a2a9e108
fix(ios): message sent to deallocated instance ( #1482 )
...
* fix(ios): message sent to deallocated instance
* chore: update changelog
2019-02-14 16:34:14 +01:00
Laurent Cozic
891add630f
Throw an error instead of crashing app when video source is empty
...
If an undefined source is accidentally loaded in react-native-video a fatal error SIGABRT will happen and crash the application. This is very difficult to debug since there's apparently no relation between this crash and react-native-video. So this change checks if the URI is empty and, if it is, it throws an error, allowing the user to find out early about the issue.
https://cloud.githubusercontent.com/assets/5795227/20283860/08223ba6-aabb-11e6-9fdc-d12d32b3aa9a.png
2019-02-11 15:24:28 +00:00
Hampton Maxwell
4424774ca3
Merge pull request #1448 from sridhard/master
...
Feature Implementation: Recovery from transient internet failures
2019-02-10 20:07:29 -08:00
Hampton Maxwell
2898f8cb5a
Revert changes to video group index unset code
...
I'm guessing this change was made to cleanup the code, however it is not functionally identical and may cause issues. Revert until those can be discussed.
2019-02-10 19:56:56 -08:00
Hampton Maxwell
420d88d583
Rename failureRetryCount to minLoadRetryCount
2019-02-10 19:54:57 -08:00
Hampton Maxwell
e4763c9d10
Rename failureRetryCount to minLoadRetryCount
2019-02-10 19:47:07 -08:00
Hampton Maxwell
35250fa8c4
Rename failureRetryCount to minLoadRetryCount
2019-02-10 19:45:31 -08:00
Hampton Maxwell
77411f2d0f
Rename failureRetryCount to minLoadRetryCount
2019-02-10 19:21:02 -08:00
Hampton Maxwell
e0fd69e9f7
Merge pull request #1414 from IbrahimSulai/master
...
Support for displaying controls in Android Exoplayer
2019-02-10 18:20:01 -08:00
Hampton Maxwell
40803496f9
Code formatting cleanups for controls
2019-02-10 18:15:30 -08:00
Hampton Maxwell
c361b795fc
Cleanup controls comment
2019-02-10 18:06:49 -08:00
Kurt Johnson
a55b7e5a24
Added details to readme and changelog
2019-02-07 11:14:27 -05:00
Kurt Johnson
739a6362bf
Fix so background audio from other apps can play when disableFocus is true. requestAudioFocus was being run regardless of there being a src, so I made it so that only gets requested when a src exists.
2019-02-07 11:02:10 -05:00
Ibrahim Sulaiman
bd8aa99645
Changed the execution order of initializePlayerControl method in order to align with player state
2019-02-06 03:22:06 +05:30
Ibrahim Sulaiman
1430dc7fea
Fix for play and pause button UI issue
2019-02-04 19:18:29 +05:30
sridhar
938cfd64a5
Defect fix for issue #1460
...
Defect fix: https://github.com/react-native-community/react-native-video/issues/1460
2019-01-30 22:43:12 +05:30
Jingsong Gao
80391d4e2a
fix: fix code block in README.md ( #1455 )
2019-01-30 16:05:27 +01:00
Ibrahim Sulaiman
c156550518
Used default playerControlView's API to show and hide controls
2019-01-28 14:50:51 +05:30
Ibrahim Sulaiman
debc0cb3c6
Resolved the playercontrol UI issue and also handled the controls prop state
2019-01-25 15:54:53 +05:30
Ash Mishra
b6ed6819f0
Fix missing layout calls in full-screen when using built-in video controls on iOS
2019-01-24 16:04:31 -08:00
sridhar
8dd782d91e
updated changelog for PR 1448
...
updated changelog for PR 1448
2019-01-24 19:25:32 +05:30
sridhar
47875ed286
Doc modifications as per alplabetical order
...
Doc modifications as per alplabetical order
2019-01-24 19:06:11 +05:30
sridhar
88e9ed6c08
Gradle changes reverted back
...
Gradle changes reverted back
2019-01-24 19:02:26 +05:30
sridhar
5c1fdfb01a
Doc changes for retry count implementation
...
Doc changes for retry count implementation
2019-01-24 18:59:54 +05:30
sridhar
172954de5a
Feature implementation: Failure Retry Count
...
Feature implementation: Failure Retry Count
2019-01-24 18:49:37 +05:30
Laurin Quast
125d5dc9c5
fix: omit packager assets from caching ( #1438 )
2019-01-24 13:15:58 +01:00
sridhar
91e0206a41
Exoplayer gradle changes
...
Exoplayer gradle changes
2019-01-24 15:44:45 +05:30
sridhar
03e2061e5a
Merge pull request #3 from react-native-community/master
...
Merge from master to my fork
2019-01-24 12:52:38 +05:30
Hampton Maxwell
0a1605f11c
Make it more clear that Android SDK changes are to target SDK
2019-01-23 10:14:25 -08:00
Laurin Quast
4dc4db3a83
fix: set the correct git url ( #1439 )
2019-01-22 11:48:53 +01:00
Rinon Beselica
59783f012f
fixed a mistake in the documentation about the headers. ( #1420 )
2019-01-22 11:10:47 +01:00
Ibrahim Sulaiman
e05c1c3c64
Resolved the review comments
2019-01-16 23:47:32 +05:30
Abdulrahman Alzenki
62dc913cb3
Address some of the feedback from the pull reqeust
2019-01-07 10:41:30 -08:00
Abdulrahman AlZanki
4a16151195
Fix typo
2019-01-07 10:26:20 -08:00
Abdulrahman Alzenki
617b046789
Implement picture in picture for iOS
...
Test Plan:
- Run on ipad
- test out onIsPictureInPictureSupported, onIsPictureInPictureActive, restoreUserInterfaceForPictureInPictureStop, startPictureInPicture, stopPictureInPicture
2019-01-07 10:26:20 -08:00
Ibrahim Sulaiman
8cffd5bc25
Updated README.
2019-01-04 15:31:49 +05:30
Ibrahim Sulaiman
4cc9a4d374
Support for controls in android exoplayer
2019-01-04 14:58:32 +05:30
Hampton Maxwell
35e26427ea
Version 4.3.1
2019-01-03 22:12:31 -08:00
Hampton Maxwell
fd90167f31
Merge pull request #1413 from react-native-community/bugfix/no-video-out-of-bounds
...
Fix Array Out of Bounds crash if no video tracks present
2019-01-03 22:12:12 -08:00
Hampton Maxwell
2d016e7e6a
Fix Array Out of Bounds crash if no video tracks present
2019-01-03 22:02:58 -08:00
Hampton Maxwell
0339727fab
Version 4.3.0
2018-12-31 22:12:13 -08:00
Hampton Maxwell
9a809e22d8
Fix mismatched bitrate vars
2018-12-31 22:08:18 -08:00
Hampton Maxwell
fb5f87bc9b
Disable onBandwidthUpdate for iOS since it's not working yet
2018-12-31 22:06:50 -08:00
Hampton Maxwell
ba439cc319
Add video track selection & onBandwidthUpdate
2018-12-31 22:04:28 -08:00
Hampton Maxwell
d249b08c25
Add dependencies needed for Haul
2018-12-31 22:04:04 -08:00
