railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Resolved the review comments

Browse Source
This commit is contained in:
Ibrahim Sulaiman 2019-01-16 23:47:32 +05:30
parent 8cffd5bc25
commit e05c1c3c64
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -361,7 +361,7 @@ Note on iOS, controls are always shown when in fullscreen mode.
Controls are not available Android because the system does not provide a stock set of controls. You will need to build your own or use a package like [react-native-video-controls](https://github.com/itsnubix/react-native-video-controls) or [react-native-video-player](https://github.com/cornedor/react-native-video-player).
Platforms: iOS, Android, react-native-dom
Platforms: iOS, Android ExoPlayer, react-native-dom
#### filter
Add video filter

10
android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
View File

@ -64,7 +64,6 @@ import com.google.android.exoplayer2.upstream.BandwidthMeter;
import com.google.android.exoplayer2.upstream.DefaultBandwidthMeter;
import com.google.android.exoplayer2.util.MimeTypes;
import com.google.android.exoplayer2.util.Util;
//Import PlayerControlView
import com.google.android.exoplayer2.ui.PlayerControlView;
import java.net.CookieHandler;
@ -98,7 +97,6 @@ class ReactExoplayerView extends FrameLayout implements
}
private final VideoEventEmitter eventEmitter;
//Create playerControlView instance
private PlayerControlView playerControlView;
private Handler mainHandler;
@ -274,9 +272,9 @@ class ReactExoplayerView extends FrameLayout implements
}
/**
* Initialising Player control
* Initializing Player control
*/
private void initialisePlayerControl() {
private void initializePlayerControl() {
playerControlView = new PlayerControlView(getContext());
LayoutParams layoutParams = new LayoutParams(
LayoutParams.MATCH_PARENT,
@ -1107,8 +1105,8 @@ class ReactExoplayerView extends FrameLayout implements
*/
public void setControls(boolean controls) {
if(controls && (exoPlayerView != null)) {
//Initialise playerControlView
initialisePlayerControl();
//Initialize playerControlView
initializePlayerControl();
}
}
}