Commit Graph

181 Commits

Author SHA1 Message Date
Hampton Maxwell
da8a202a0f
Make video auto track selection more readable 2019-04-03 23:24:02 -07:00
Jacob
2072793ae3
Fix Android audio crash
Why:

* There is a case where groupIndex may be unset

This change addresses the need by:

* Don't chain check for INDEX_UNSET to previous conditional
2019-03-19 13:46:01 -04:00
Kurt Johnson
3d80bfd236
Merge branch 'master' into bugfix/android-disablefocus-audio 2019-03-15 15:57:00 -04:00
Marius Reimer
300f28335f Adding compileOptions Java 1.8 to build.gradle 2019-02-26 11:21:28 +01:00
Hampton Maxwell
4424774ca3
Merge pull request #1448 from sridhard/master
Feature Implementation: Recovery from transient internet failures
2019-02-10 20:07:29 -08:00
Hampton Maxwell
2898f8cb5a
Revert changes to video group index unset code
I'm guessing this change was made to cleanup the code, however it is not functionally identical and may cause issues. Revert until those can be discussed.
2019-02-10 19:56:56 -08:00
Hampton Maxwell
e4763c9d10
Rename failureRetryCount to minLoadRetryCount 2019-02-10 19:47:07 -08:00
Hampton Maxwell
35250fa8c4
Rename failureRetryCount to minLoadRetryCount 2019-02-10 19:45:31 -08:00
Hampton Maxwell
40803496f9
Code formatting cleanups for controls 2019-02-10 18:15:30 -08:00
Kurt Johnson
739a6362bf Fix so background audio from other apps can play when disableFocus is true. requestAudioFocus was being run regardless of there being a src, so I made it so that only gets requested when a src exists. 2019-02-07 11:02:10 -05:00
Ibrahim Sulaiman
bd8aa99645 Changed the execution order of initializePlayerControl method in order to align with player state 2019-02-06 03:22:06 +05:30
Ibrahim Sulaiman
1430dc7fea Fix for play and pause button UI issue 2019-02-04 19:18:29 +05:30
sridhar
938cfd64a5 Defect fix for issue #1460
Defect fix: https://github.com/react-native-community/react-native-video/issues/1460
2019-01-30 22:43:12 +05:30
Ibrahim Sulaiman
c156550518 Used default playerControlView's API to show and hide controls 2019-01-28 14:50:51 +05:30
Ibrahim Sulaiman
debc0cb3c6 Resolved the playercontrol UI issue and also handled the controls prop state 2019-01-25 15:54:53 +05:30
sridhar
88e9ed6c08 Gradle changes reverted back
Gradle changes reverted back
2019-01-24 19:02:26 +05:30
sridhar
172954de5a Feature implementation: Failure Retry Count
Feature implementation: Failure Retry Count
2019-01-24 18:49:37 +05:30
sridhar
91e0206a41 Exoplayer gradle changes
Exoplayer gradle changes
2019-01-24 15:44:45 +05:30
Ibrahim Sulaiman
e05c1c3c64 Resolved the review comments 2019-01-16 23:47:32 +05:30
Ibrahim Sulaiman
4cc9a4d374 Support for controls in android exoplayer 2019-01-04 14:58:32 +05:30
Hampton Maxwell
2d016e7e6a Fix Array Out of Bounds crash if no video tracks present 2019-01-03 22:02:58 -08:00
Hampton Maxwell
9a809e22d8 Fix mismatched bitrate vars 2018-12-31 22:08:18 -08:00
Hampton Maxwell
3c313e2e61 Revert build.gradle changes from video track selection PR 2018-12-31 21:57:31 -08:00
Hampton Maxwell
45a851e79a
Merge branch 'master' into master 2018-12-31 21:36:49 -08:00
Hampton Maxwell
7f2c4ab0ed
Reenable ExoPlayer exclusions 2018-12-31 21:36:02 -08:00
Hampton Maxwell
d148c3f9f9
Change field to bitrate for bandwidth update 2018-12-31 21:35:15 -08:00
Hampton Maxwell
d5168af211
Cleanups to video track handling.
This also fixes a bug that compared track type & renderer index
2018-12-31 21:33:02 -08:00
Hampton Maxwell
05d9d360f8 Update to OkHTTP 3.12.1 and ExoPlayer 2.9.3 2018-12-31 13:51:29 -08:00
Hampton Maxwell
7837c39df0
Merge pull request #1373 from reime005/android-subtitle-fix
[WIP] Fix android subtitle issue caused by using rawdatasource
2018-12-31 13:37:02 -08:00
sridhar
756bbc96f0 Defect fix
Defect fix
2018-12-20 11:01:13 +05:30
Hampton Maxwell
5a053a7469 Fix bug where useTextureView wasn't defaulting to true 2018-12-13 10:05:09 -08:00
Hampton Maxwell
00dac26a63
Always convert maxBitRate of 0 to Integer.MAX_VALUE 2018-12-13 09:50:43 -08:00
Hampton Maxwell
a43f9c7ce1
Merge branch 'master' into maximumBitRate-adaptive-streaming 2018-12-12 22:30:52 -08:00
Marius Reimer
bf4a7df0e7 Fix android subtile issue caused by using rawdatasource 2018-12-09 00:40:05 +01:00
vadim
96c42844fe ExoPlayer - Add possibility to hide shutterView 2018-11-28 14:56:58 +02:00
Hampton Maxwell
413a7b87c6 Only fire onSeek once we've completed the seek operation 2018-11-27 19:48:41 -08:00
Ash Mishra
5ab8165c3d renamed maximumBitRate to maxBitRate. Added applyModifiers support 2018-11-26 14:50:31 -08:00
Ash Mishra
11db343987 Support for HLS maximum bit rate adaptive streaming 2018-11-26 10:33:09 -08:00
Hampton Maxwell
05ae20c772 Update ExoPlayer to 2.9.1 and OkHTTP to 3.12.0 2018-11-21 00:07:11 -08:00
Daniel Dudek
5c7da30ddb Fixed volume change when audio focus change 2018-11-14 12:33:28 +01:00
sridhar
5dce3e2161 Code cleanup
Code cleanup
2018-11-01 21:41:57 +05:30
sridhar
9dead2fefc Some log functions removed
Some log functions removed
2018-11-01 16:58:27 +05:30
sridhar
41cbf073c7 Bandwidth is reported as enevts when download happens. Not by timer method
Bandwidth is reported as enevts when download happens. Not by timer method
2018-11-01 15:18:59 +05:30
sridhar
aa526206d2 Merge branch 'master' of git://github.com/react-native-community/react-native-video into react-native-community-master
Merge branch 'master' of git://github.com/react-native-community/react-native-video into react-native-community-master
2018-10-27 09:19:28 +05:30
Hampton Maxwell
3eb8515461 Don't pause when detaching 2018-10-13 20:36:12 -07:00
Hampton Maxwell
2d76e491d3
Switch useTextureView to default to true (#1286)
A number of people run into SurfaceView layering issues. It seems better to default to the more compatible option and let people reconfigure if they need the extra SurfaceView performance.
2018-10-13 20:23:30 -07:00
Hampton Maxwell
d87568db0e
Feature/exoplayer 2.9 (#1285)
Update to ExoPlayer 2.9.0 & document version 4.0.0 breaking changes
2018-10-13 20:16:10 -07:00
Hampton Maxwell
051a2c39f4
Merge branch 'master' into fix/gradle3 2018-10-13 19:18:13 -07:00
Hampton Maxwell
e50c2ad314 Update to ExoPlayer 2.8.4 2018-10-07 12:53:58 -07:00
Hampton Maxwell
5e360608af Return unset track index when there are no track available (#1190) 2018-09-12 19:38:11 -07:00
sridhar
654a76d6ef named parameter added for exception. Otherwise this cannot be used in JS
named parameter added for exception. Otherwise this cannot be used in JS
2018-09-06 14:25:44 +05:30
Tom Spencer
00174b63b8 Support RN 0.57 w/ gradle 3 2018-09-06 09:44:27 +01:00
sridhar
6480a6462b Reporting estimatedBandwidth
Reporting estimatedBandwidth
2018-08-25 21:53:11 +05:30
sridhar
ff31bd1772 reverted deprecated API
reverted deprecated API
2018-08-25 11:24:08 +05:30
sridhar
4ea926e137 Bandwidth reporting
To show the current bandwidth to user and for debugging purposes current bandwidth is required to be reported. This pull request adds the bandwidth estimate in the progress event.

Also the bandwidth details are added in the audio track in load event. There is another pull request which reports the video track information
2018-08-25 11:21:01 +05:30
sridhar
16688cef0f Youtube like video track selection
1. Loaded event will give the information about available video tracks
2. selectedVideoTrack prop will give the interface to select the video track. This prop will take the height of the video (Similar to youtube like 144p, 350p etc) and set the video track. If height is 0 then all video tracks will be added to list so that it will work like 'Auto' in youtube
2018-08-24 15:33:46 +05:30
Hampton Maxwell
40cafdcb2e Upgrade to ExoPlayer 2.8.2 2018-08-07 23:10:03 -07:00
Hampton Maxwell
f0ee821225 Change ExoPlayer version to 2.8.2 2018-08-06 14:23:33 -07:00
Hampton Maxwell
a60a1277b7
Remove extra space 2018-08-03 15:54:55 -07:00
Hampton Maxwell
725497e149
Don't set isPaused when releasing the player
I'm guessing this was a bug as it doesn't make sense that we would set paused to true if the video is playing, and not paused if it wasn't. I believe this is a safe change since we only release the player when the app is closing or we detach (which is going away shortly). We need this since we release the player in order to apply new bufferConfig settings.
2018-08-03 15:54:18 -07:00
Bryan van Wijk
cd75e72180 Rename to bufferConfig and use stopPlayback 2018-08-02 09:20:08 +02:00
Bryan van Wijk
dde27a320e Pass loadControl parameters as video props 2018-08-01 15:58:02 +02:00
Bryan van Wijk
092ba33e95 Expose DefaultLoadControl parameters Android 2018-07-31 17:23:20 +02:00
Hampton Maxwell
1c9f2caa19 Apply SDK vars simplification 2018-07-24 13:19:45 -07:00
Hampton Maxwell
06eb1c57d8 Support selecting audio tracks
Implements audio track selection on iOS & Android ExoPlayer. The prop mirrors the API for selectedTextTrack.
2018-07-17 14:14:21 -07:00
Hampton Maxwell
2d5ef8cfd2 Update name of onAudioBecomingNoisy 2018-07-12 21:49:14 -07:00
Ash Mishra
6339b9ac08 isPaused reverted
clearSelectionOverride is still required for "default" and "disabled" case as it otherwise continues to show a selected track if it was previously selected
2018-07-09 16:18:42 -07:00
Ash Mishra
572c11a1dc Android device locale support for captions 2018-07-09 11:36:35 -07:00
Ash Mishra
05d4be2d9c Merge remote-tracking branch 'upstream/master'
# Conflicts:
#	ios/RCTVideo.m
#	package.json
2018-07-06 16:01:02 -07:00
Ash Mishra
3e2e16ef44 iOS Sidecar loading for captions and offline support (isAsset). Android
fix to respect User settings for captions.
2018-07-05 13:36:36 -07:00
Hampton Maxwell
9c0ddde131 playableDuration was not converting the percentage to a decimal 2018-06-25 12:25:14 -07:00
Hampton Maxwell
c67dd7b8ef
Merge branch 'master' into master 2018-06-22 18:57:58 -07:00
Hampton Maxwell
954a97a73f
Merge pull request #1081 from react-native-community/revert-1080-revert-999-master
Reapply "Using SDK Version variables from root project""
2018-06-22 13:17:07 -07:00
Hampton Maxwell
c80aa33775 Automatically play when the paused prop is not set 2018-06-21 22:36:24 -07:00
Hampton Maxwell
20f9c291cd
Revert "Revert "Using SDK Version variables from root project"" 2018-06-21 10:29:38 -07:00
Hampton Maxwell
7511487baf
Revert "Using SDK Version variables from root project" 2018-06-21 09:18:12 -07:00
Hampton Maxwell
b850b31f04 Return empty string instead of null if text track title or language are not set 2018-06-20 15:46:04 -07:00
Hampton Maxwell
e684ba65b6 Fix crash when selectedTextTrack is null or undefined 2018-06-20 15:34:36 -07:00
Hampton Maxwell
d47a6ed424 Specify the text track type without any conversion 2018-06-12 20:57:30 -07:00
Hampton Maxwell
e2ea849d9e Add ability to sideload text tracks and report them in onLoad 2018-06-11 21:25:58 -07:00
Hampton Maxwell
8aac3dd905 Testing sideloaded text tracks 2018-06-11 15:23:43 -07:00
Hampton Maxwell
a0066675a9 Remove the LoopingMediaSource since we repeat with other means 2018-06-09 17:13:14 -07:00
Hampton Maxwell
13601b9991
Merge branch 'master' into master 2018-06-09 16:48:13 -07:00
Hampton Maxwell
da7bd43011
Revert setPlayWhenReady change 2018-06-09 16:13:58 -07:00
Hampton Maxwell
fab55f4d5c
Merge branch 'master' into master 2018-06-09 16:11:55 -07:00
Hampton Maxwell
d3bda4a204
Don't affect pause status after playing in the background 2018-06-09 16:11:18 -07:00
Emrah
2d89a3fd54
Merge branch 'master' into master 2018-06-09 21:36:09 +02:00
Emrah Kaya
623b562295 resolving conflicts 2018-06-09 21:30:38 +02:00
Hampton Maxwell
066a0c9c16 Add support for using a TextureView in ExoPlayer 2018-06-08 00:01:13 -07:00
Hampton Maxwell
11584f28d1 Apply initial text track prop when the video is loaded 2018-06-04 11:48:59 -07:00
Hampton Maxwell
4d008e56f2 Add disabled text track selection option 2018-06-02 19:41:50 -07:00
Hampton Maxwell
9764fe3be4 First pass at text track selection, mostly complete 2018-06-02 02:24:13 -07:00
Hampton Maxwell
d716ee48d9
Merge pull request #922 from brandonmoon/link-exoplayer-with-cookies
Link exoplayer with cookies
2018-06-01 11:56:16 -07:00
Hampton Maxwell
0776179834
Re-use the existing OkHttpClient
Use the client we create earlier in the function
2018-06-01 11:55:43 -07:00
Hampton Maxwell
5ce228e9f7
Minor formatting cleanups
Fix spacing
2018-06-01 11:55:00 -07:00
Hampton Maxwell
c8d44448c7 Remove obsolete metadata code that shouldn't have been included 2018-05-29 15:25:29 -07:00
Hampton Maxwell
fefbe801ef
Merge branch 'master' into master 2018-05-29 15:08:24 -07:00
Hampton Maxwell
6ecaa7420b Add missing import for Exoplayer Player library 2018-05-28 23:25:33 -07:00
Hampton Maxwell
39d8c4384b Add a comment about why we send onEnd from onPositionDiscontinuity when repeat is on 2018-05-28 21:26:23 -07:00
Hampton Maxwell
5a43f62253 Generate an onEnd event when the end of the video is reached while repeat is on 2018-05-28 21:22:47 -07:00