Commit Graph

416 Commits

Author SHA1 Message Date
Gaëtan Kueny
051e884c8f
fix(ios): call PictureInPicture callbacks with native controls (#3603)
* fix(ios): call PictureInPictureStatusChanged callback with native controls

We add RCTPlayerObserver as playerViewController delegate to be notified with PiP lifecycle
should partially fix #3602

* fix(ios): call onRestoreUserInterfaceForPictureInPictureStop callback with native controls

should partially fix #3602
2024-04-04 15:08:48 +02:00
Krzysztof Moch
10b100de44
feat!(ios): remove native dependency promises (#3631) 2024-04-04 13:23:44 +02:00
Olivier Bouillet
75d370742b
fix(ios): fix regression when playing source starting with ph:// (#3630) 2024-03-29 19:47:04 +01:00
Krzysztof Moch
0312afc8ea
fix: remove setNativeProps usage (#3605)
* fix: remove `setNativeProps` usage

* code review
2024-03-28 11:22:04 +01:00
Gaëtan Kueny
bb9e7eb5a5
fix(ios): fix PiP callback (#3601) 2024-03-26 14:10:31 +01:00
YangJH
c9a75f3cde
fix(iOS): fix iOS DRM header parser (#3609) 2024-03-26 13:56:22 +01:00
YangJH
098358076d
fix(iOS): throw when content id defined with empty string (#3612) 2024-03-26 13:55:11 +01:00
YangJH
36bd2e2d71
fix(ios): fix startPosition, cropStart and cropEnd to handle float values correctly (#3589)
* refactor(ios): refactor setPlaybackRange function

* fix(ios): fix props to handle float values correctly

- fix startPosition, cropStart, cropEnd

* refactor(ios): apply lint
2024-03-22 13:43:46 +01:00
Olivier Bouillet
41c6785ee8
fix(ios): ensure playback stopped in background (#3587)
* feat!: move require source to `uri`

* pass other source properties

* chore: update basic example

* chore: restore backward compatibility

* docs: update source via require

* fix types

* make docs build workflow pretty

* doc: keep previous doc and add more info

* fix: do not pause playback in handlePlaybackLikelyToKeepUp

and review onBuffer event (not yet clean)

---------

Co-authored-by: Krzysztof Moch <krzysmoch.programs@gmail.com>
2024-03-15 12:02:17 +01:00
Olivier Bouillet
429fddf3b0
Fix(ios): fix real time issue when fast zapping (#3582)
* fix(ios): fix real time issue when doing fast zapping

* fix(ios): fix delay implementation (timing was not applied correctly)

* chore: fix random crash in sample

* chore: fix linter
2024-03-14 11:46:45 +01:00
coofzilla
f4cce2ecdb
feat: implement opacity to control visibility of subtitles (#3583)
* feat: implement opacity to control visibility of subtitles

implemented per discussion on https://github.com/react-native-video/react-native-video/issues/3579

updated docs and linked onTextTrackDataChanged to the subtitle style to clarify intent on how to control visibility.

* chore: update type so that we use a union of 0 1 vs any number

* chore: run ktlint to get rid of white spaces

* feat: add ability to have range of numbers for opacity; while, 0 will still not render the subtitles.

added util function for safeGetFloat

updated types

* feat: add ability to suppress subtitles with opacity 0

add data structure for subtitle styles for extensibility

* chore: run yarn check-ios

* chore: update documentation to clarify differences between android and ios

* Update android/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java

Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>

---------

Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
2024-03-14 11:29:50 +01:00
Olivier Bouillet
7c4d19fa72
fix(ios): split licenseUrl and loadedLicenseUrl (#3578)
* fix(ios): split licenseUrl and loadedLicenseUrl
* fix(ios): fix drm license url used to provide the answer
2024-03-12 16:47:49 +01:00
Krzysztof Moch
90b31af2c9
fix(ios): don't crop video when in repeat mode (#3575) 2024-03-10 21:12:47 +01:00
Krzysztof Moch
46c8c498c4
fix(ios): fix missing bridge in bridgeless mode (#3570) 2024-03-07 20:16:11 +01:00
yungblud
b33e6df496
Fabric (New Architecture) codegen support (#3487)
* feat: implemented codegenConfig on package.json

* chore: moved directory location of Fabric component

* fix: typefix FabricExample

* chore: pod instaslled FabricExample iOS app

* feat: implemented codegen config on package.json

* feat: implemented codegen of specs/VideoNativeComponent

* chore: removed not using type Filter

* feat: removed unnecessary export on codegen tyepes

* Revert "feat: removed unnecessary export on codegen tyepes"

This reverts commit fc243b0ac5c565eda4886cd865c32ba4e812d7ff.

* refactor: fixed types on Video component and modified types with codegen types

* feat: modified codegenNativeComponent naming (RCTVideo)

* feat: pod installed example basic app

* feat: bump up react-native dev dependency version to 0.73.2 for supporting codegen array event params

* feat: support array param types on event callback function codegen types

* chore: pod installed ios basic example

* feat: modified source prop as optional type

* feat: add original src/VideoComponent.ts again

* Revert "feat: add original src/VideoComponent.ts again"

This reverts commit d63ac94e5330f7c7fb50374f65f8f3f4e0a225d7.

* feat: add original src/VideoComponent.ts again with original file name

* feat: git rm src/specs/VideoNativeComponent.ts

* feat: git mv VideoNativeComponent.ts

* feat: git mv src/specs/VideoNativeComponent.ts

* feat: git mv src/VideoNativeComponent.ts src/specs/VideoNativeComponent.ts

* feat: implemented array type handling on android JAVA

* feat: updated iOS requestHeaders parsing native

* feat: use safeGetArray on android, removed not using import too

* feat: temporary commit - reusing enum types for remaining docs types

* feat: implemented mixed type of SelectedTrack.value for JS layer
2024-03-07 11:35:17 +01:00
jerrylc
16f3cdbd9a
fix(ios): current release volume change observer (#3565)
Co-authored-by: jerrylc.liu <jerrylc.liu@dji.com>
2024-03-06 23:55:44 +01:00
Gaëtan Kueny
b73baad2c2
fix(ios): add text tracks only if we successfully insertTimeRage (#3557)
insertTimeRage can fail & if we add failed textTrack to our validTextTracks array, video can crash later on selectTextTrack
we also add en empty textTrack only we we have validTextTrack

related to https://github.com/react-native-video/react-native-video/issues/3480
2024-03-04 10:43:33 +01:00
coofzilla
253ffb5956
feat(ios): Add ios support for accessing WebVTT Subtitle Content (#3541)
* feature: add support to get subtitle content data

* refactor: return a string of the subtitles

Push the parsing/formatting to the consumer side.

* chore: add types for new subtitle feature

* chore: run swiftlint and swiftformat

* chore: add documentation for new onSubtitleTracks callback

* chore: added test uri; basic implementation of feature; hotfix onTextTracks

added optional chaining for `return x?.selected` because tracks that don't have a track selected either by default or manually will return undefined and this can cause an error.

* feat: rename onSubtitleTracks to onTextTrackDataChanged

Renamed the onSubtitleTracks event to onTextTrackDataChanged across the codebase to clearly indicate the callback's purpose: being called when the text track's data changes. This change is reflected in the events documentation, example usage in VideoPlayer.tsx, and the relevant iOS implementation files for consistency and clarity, in line with PR feedback.

* chore: omit target property

target could be confusing for users so we have removed it. using the delete operator instead of using {target,...eventData} as that would give an eslint error about unused vars.
2024-02-29 14:41:04 +01:00
Gaëtan Kueny
4d4b56c05d
fix(ios): Do not crash when accessLog return nil (#3549)
accessLog method can return nil if no logging information are currently available (see https://developer.apple.com/documentation/avfoundation/avplayeritem/1388499-accesslog).
So we handle this case & do not call onVideoBandwidthUpdate

fix https://github.com/react-native-video/react-native-video/issues/3424
2024-02-29 14:40:11 +01:00
Krzysztof Moch
2c0e009876
fix(ios): apply cropStart when in repeat mode (#3525) 2024-02-08 14:59:33 +01:00
Krzysztof Moch
9306d9a15d
fix(ios): fix tvOS build (#3524) 2024-02-08 14:59:13 +01:00
Olivier Bouillet
6a49cba273
feat: implement onAudioTracks and onTextTracks on ios (#3503)
* feat: implement onAudioTracks and onTextTracks on ios

* chore: lint code

* fix: rework previous fix to fix linter and be more aligned with architecture

---------

Co-authored-by: olivier <olivier.bouillet@ifeelsmart.com>
2024-02-01 08:56:00 +01:00
Krzysztof Moch
53068ddd41
fix(ios): fix pip memory leak (#3506)
* fix(ios): fix pip memory leak

* lint code
2024-01-30 08:33:33 +01:00
YangJH
e63c7cbd30
refactor(ios): remove type assertion within setupPipController (#3493)
* refactor(ios): remove type assertion within setupPipController

* lint: apply swift lint
2024-01-24 07:54:58 +01:00
Krzysztof Moch
cf3ebb7f15
feat: add visionOS support (#3425)
* feat: add visionOS to target platforms

* disable unsupported API

* add temporary `promises` patches

* fix(visionOS): update promises patches

* apply code review suggestions

* format code
2024-01-15 08:04:29 +01:00
Bryan
8f1bdb7c36
Externally loaded text tracks not loading properly (#3461)
* fix text tracks

* keep map

* use where

* update change log

* fix build error
2024-01-15 07:31:22 +01:00
Jordan Grant
045f5fa008
fix(ios): remove extra dismissFullscreenPlayer declaration (#3474) 2024-01-15 07:31:00 +01:00
Kubessandra
3f63c161eb
fix(ios): currentPlaybackTime in ms and not seconds (#3472) 2024-01-14 03:08:34 +01:00
Krzysztof Moch
5aaa53d8b8
feat(ios): migrate from deprecated methods (#3444)
* feat(ios): migrate from deprecated methods

* fix types
2024-01-06 20:06:53 +01:00
Krzysztof Moch
2ed3949307
chore(linter/swift): add shorthand_optional_binding rule (#3456)
* chore(linter/swift): add `shorthand_optional_binding` rule

* lint code
2024-01-04 20:16:23 +01:00
Krzysztof Moch
481cc71eda
feat(ios): update timed metadata handler (#3449)
* feat(ios): update timedmetadata handler

* chore: move metadata output delegate to main queue

* code clean

* apply code review nit
2024-01-04 14:14:51 +01:00
Krzysztof Moch
f35727f30e
feat(ios): update the way to get keyWindow (#3448)
* feat(ios): update the way to get `keyWindow`

* lint
2023-12-28 12:58:25 +01:00
Konstantin
0723481fee
fix(ios): revert ios url encoding as this breaks encoded urls (#3440) 2023-12-24 14:32:24 +01:00
Krzysztof Moch
800aee09de
chore: lint project (#3395)
* chore: format swift code
* chore: format clang code
* chore: format kotlin code
* refactor: rename folder "API" to "api"
2023-12-07 08:47:40 +01:00
Krzysztof Moch
91d7135562
chore: enhance CI tests (#3344)
* chore: add swift linter

* chore: add clang linters

* chore: add kotlin linter

* chore(ci): update workflows

* chore(ci): clean workflows
2023-12-02 15:58:43 +01:00
Axel Vencatareddy
596c02d2b3
feat: add onAdError event listener (#3381)
* feat: add onAdError event listener
* feat: remove onAdError event listener and use already existing
* feat: add ERROR event to docs
2023-12-02 13:52:01 +01:00
Axel Vencatareddy
d05231d76b
feat(ad): add data to onReceiveAdEvent (#3378)
* feat(ad): add adData to onReceiveAdEvent
* fix: remove adData from response if empty
* fix: add getAdData to stub file
* chore: fix build without IMA
* fix: rename `adData` to `data`

---------

Co-authored-by: olivier <olivier.bouillet@ifeelsmart.com>
2023-11-27 21:43:30 +01:00
JuozasP
de4159f0c2
fix(ios): check for ios url query encoding (#3384)
Co-authored-by: Juozas Petkelis <juozas.petkelis@kilo.health>
2023-11-26 21:20:29 +01:00
YangJH
2648502b36
feat: implement startPosition (#3355)
* feat(android): implement startPosition

* feat(ios): implement startPosition

* feat: implement startPosition type

* docs: fix typo

* docs: update startPosition

* refactor: put startPosition inside source prop
- put startPosition inside source prop
- rename existing prop (startTime, endTime)

* docs: update startPosition property description

* fix: fix invalid assignments

* refactor: remove redundant optional chaining

* feat: allow "0" to work too
2023-11-24 12:52:46 +01:00
Axel Vencatareddy
364944b329
BREAK: fix(android): harmonize IMAAdEventType between iOS and Android (#3373) 2023-11-23 08:45:47 +01:00
YangJH
11f62013e3
fix(ios): fix pip(when player doesn't fill screen) (#3363) 2023-11-20 08:43:35 +01:00
Krzysztof Moch
1ba93f9e9d
fix(ios): change isPlaybackLikelyToKeepUp check (#3357) 2023-11-17 17:35:22 +01:00
Krzysztof Moch
0e23952cea
fix(ios): fix cache playerItemPrepareText type (#3358) 2023-11-17 15:09:28 +01:00
Krzysztof Moch
782e7e0df1
fix(ios): fix external text tracks crashes with m3u8 files (#3330)
* fix(ios): fix crash when using textTracks with m3u8

* docs: add warning to `textTracks` prop

* chore: apply code review

* chore: remove indents
2023-11-17 08:19:39 +01:00
Olivier Bouillet
8777b0a35e
Fix(ios): another video caching fix (#3348)
* fix: another fix from video caching

---------

Co-authored-by: olivier <olivier.bouillet@ifeelsmart.com>
2023-11-16 22:13:53 +01:00
Olivier Bouillet
dfac7a6ed3
Fix(ios): restore caching feature (#3341)
* chore: fix build issue

* fix: try to fix save typings

* chore: fix podspec

* fix: update integration guide for ios Caching

* fix: update sample to test the save function

---------

Co-authored-by: olivier <olivier.bouillet@ifeelsmart.com>
2023-11-13 21:36:16 +01:00
Krzysztof Moch
9054db35d7
feat(ios): add onBandwidthUpdate event (#3331)
* feat(ios): add onBandwidthUpdate event
2023-11-08 22:06:29 +01:00
YangJH
7f49b56027
fix(ios): fix wrong fullscreen method definition (#3338) 2023-11-08 19:04:39 +01:00
Andrii Drobiazko
722ae3477a
fix(ios): player is frozen after re-focusing on the app (#3326)
* [bugfix] player is frozen after re-focusing on the app

* Fix playback rate on resume

Co-authored-by: Krzysztof Moch <krzysmoch.programs@gmail.com>

---------

Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
Co-authored-by: Krzysztof Moch <krzysmoch.programs@gmail.com>
2023-11-06 10:20:42 +01:00
Krzysztof Moch
cdbc856387
feat: add onVolumeChange event (#3322)
* feat: implement `onVolumeChange` event
2023-11-04 18:11:54 +01:00
Krzysztof Moch
286418e4a5
fix(ios): remove false calls at onPlaybackRateChange (#3306) 2023-10-24 22:10:29 +02:00
Krzysztof Moch
9373493d6a
feat(ios): implement onPlaybackStateChanged callback (#3307)
* chore: fix typo

* feat(ios): implement onPlaybackStateChanged

* docs: update onPlaybackStateChanged platforms
2023-10-23 18:23:57 +02:00
Krzysztof Moch
7fd7b3ff32
feat: refactor resize prop handler (#3286) 2023-10-11 21:56:54 +02:00
Craig Martin
0ad2e52499
Fix: iOS - audio does not work with headphones (#3284)
* Fix: Make AVAudioSession.Category.playAndRecord opt-in
* Fix: Call configureAudio when audioOutput is changed
* Update CHANGELOG.md
2023-10-09 22:27:29 +02:00
Konstantin
a855284d8d
feat(tvos): add custom image metadata option for tvos and add missing types for custom metadata properties (#3280)
* fix: add typescript types for custom metadata properties
* chore: add possibility to override image metadata of video playback

---------

Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
2023-10-07 15:14:10 +02:00
Leonardo Russo
e6e8f621fe
fix(ios): resuming video ad after closing the in-app browser on iOS (#3275) 2023-10-06 18:43:35 +02:00
Konstantin
7b6b84c8cb
fix(tvOS): compile issues with tvOS linked to earpiece & pip (#3276) 2023-10-06 18:42:53 +02:00
Facundo Gutierrez
f4acaccd80
fix(ios): fairplay different key per asset (#3261)
* [Fix] Replace _loadingRequest instance with _loadingRequests dictionary to support multiple concurrent requests
* Remove stored finished requests from dictionary
* Keep contentId as is, and send loadingRequest.url in licenseUrl.
* Update DRM.md

---------

Co-authored-by: Facundo Gutierrez <facundo.gutierrez@tcc.com.uy>
2023-10-05 21:37:28 +02:00
Krzysztof Moch
6e98cb9700
Merge branch 'master' into feat/playback-ref-functions 2023-09-29 22:44:32 +02:00
Olivier Bouillet
0655e9d273
Merge pull request #3239 from iFeelSmart/fix/compile_xcode_17_beta
fix: fix build on xcode 17 beta
2023-09-27 22:06:04 +02:00
KrzysztofMoch
f9743fdbd6 chore: invert setPlayerPauseState logic 2023-09-22 09:04:20 +02:00
KrzysztofMoch
421712825b chore: rename setPlayerStatus to setPlayerPauseState 2023-09-21 07:25:21 +02:00
Olivier Bouillet
01a47840be
Merge pull request #3248 from yooasd11/master
fix: Player shows black screen on re-enter (iOS)
2023-09-20 11:00:56 +02:00
Coco
be8cdfdd33 [bugfix] Player shows black screen on re-enter 2023-09-19 17:42:48 +09:00
KrzysztofMoch
85c9e8f990 feat(ios): add playback functions to ref 2023-09-18 11:46:39 +02:00
lrusso
59236c7034 fix: not showing video ads in pip mode 2023-09-17 16:12:46 -03:00
olivier
a18953e701 fix: fix build on xcode 17 beta 2023-09-14 22:41:42 +02:00
Olivier Bouillet
a0fa8312ba
Merge pull request #3216 from Duell10111/tvos-custom-playback-exerpience-fork
feat: allow customization of tvOS playback expierence
2023-09-13 21:27:37 +02:00
Konstantin Späth
33c0be449a chore: outsource functions to own utils file 2023-09-09 16:15:51 +02:00
Olivier Bouillet
267181be73
Merge pull request #3230 from iFeelSmart/fix/presentFullscreenPlayerImplementation
fix: implement lost presentFullscreenPlayer & dismissFullscreenPlayer
2023-09-05 18:48:17 +02:00
olivier
ddc87acf84 fix: implement lost presentFullscreenPlayer & dismissFullscreenPlayer
These apis has been removed during swift porting
2023-09-04 23:57:45 +02:00
Olivier Bouillet
30dac90959
Merge pull request #3221 from lrusso/master
Fixing the PIP mode on iOS
2023-09-04 23:42:01 +02:00
lrusso
63f0344742 rollback logic 2023-09-04 17:34:46 -03:00
lrusso
14f12df9f8 rollback logic 2023-09-04 17:33:21 -03:00
Olivier Bouillet
0bf7f70e24
Merge pull request #3211 from mysport12/master
Feature: audioOutput - Play over phone earpiece
2023-08-31 08:25:12 +02:00
lrusso
03cba605ea preventing the iOS pip to be closed automatically when sending to the background 2023-08-30 22:22:31 -03:00
lrusso
7c8244bd07 activating the audio session 2023-08-30 01:45:06 -03:00
lrusso
a0450e026c activating the audio session 2023-08-30 01:43:22 -03:00
lrusso
35256062d9 fixing PIP mode on iOS 2023-08-28 14:55:34 -03:00
Konstantin Späth
ae17aa747e chore: fix iOS build for custom metadata 2023-08-25 12:54:37 +02:00
Konstantin Späth
6cbc7cdc89 chore: add chapter images 2023-08-25 12:54:37 +02:00
Konstantin Späth
b225b0f800 chore: add custom titles, description and chapters 2023-08-25 12:54:37 +02:00
Konstantin Späth
fd2e396262 fix: fix tvos available compile errors 2023-08-25 12:54:35 +02:00
Craig Martin
db6e73e035 Merge remote-tracking branch 'upstream/master' 2023-08-22 22:31:30 -04:00
Konstantin Späth
a7a03901f2 fix: fix tvos available compile errors 2023-08-13 14:58:57 +02:00
Craig Martin
dc3e83a3d5 Merge remote-tracking branch 'upstream/master' 2023-07-27 16:24:11 -04:00
aravind
ccff99faff fix ios block ui issue 2023-07-12 12:41:48 +05:30
Cedric Guinoiseau
6190fff4e4 Merge commit '23a39e8f5fffbbdcfc72a4c0d7777763e273cd6d' into feature/ios-fix
* commit '23a39e8f5fffbbdcfc72a4c0d7777763e273cd6d':
  chore: fix build issue
  Update issue templates
  feat: RN 0.73 support
  Fix ids in exo_player_control_view
  fix: remove dummy nativeOnly
2023-07-09 20:46:01 +02:00
Cedric Guinoiseau
71c3c5c940 Revert "fix: issue 2744, call replaceCurrentItem in dispatch thread"
This reverts commit 12d7dd6d8b.
2023-07-09 20:44:58 +02:00
olivier
c23bcddc9b chore: fix build issue 2023-07-08 23:20:09 +02:00
Cedric Guinoiseau
238daf8720 fix: issue 3085, onFullscreen call backs are never fired 2023-07-06 11:16:49 +02:00
Cedric Guinoiseau
50b3650e2f fix: memory leak due to [weak self] and delegate not being weak 2023-07-06 09:52:33 +02:00
Cedric Guinoiseau
d526479fe0 fix: issue 3040, prevent crash 2023-07-06 09:37:02 +02:00
Cedric Guinoiseau
12d7dd6d8b fix: issue 2744, call replaceCurrentItem in dispatch thread 2023-07-06 09:33:05 +02:00
Olivier Bouillet
3bd032b720
Merge pull request #3047 from Romick2005/master
Print error for configureAudio method try catch blocks.
2023-04-29 14:39:40 +02:00
Craig Martin
dc41c65d62 Fix audio output not being properly set for iOS 2023-04-14 15:12:13 -04:00
Romick2005
87859bcc79
Update ios/Video/Features/RCTPlayerOperations.swift
Co-authored-by: Olivier Bouillet <62574056+freeboub@users.noreply.github.com>
2023-04-05 23:50:22 +03:00
Olivier Bouillet
afcde3e335
Merge branch 'master' into AndroidRangePlayback 2023-04-05 22:49:22 +02:00
Olivier Bouillet
89454311d5
Merge pull request #3077 from francescoben/bug/3068_ios_ads_muted
fix: iOS Ads are reproduced with sound even if muted or volume set to 0
2023-04-05 22:40:38 +02:00
Olivier Bouillet
d5f12b92f3
Merge pull request #3064 from Sunbreak/fix-current-time
fix: remove undocumented currentTime property
2023-04-05 22:26:25 +02:00