fix(ios): fix pip memory leak (#3506)

* fix(ios): fix pip memory leak * lint code
2024-01-30 08:33:33 +01:00
parent aec7db6390
commit 53068ddd41
1 changed files with 6 additions and 1 deletions
--- a/ios/Video/RCTVideo.swift
+++ b/ios/Video/RCTVideo.swift
@@ -140,7 +140,11 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
        _eventDispatcher = eventDispatcher

        #if os(iOS)
-            _pip = RCTPictureInPicture(self._onPictureInPictureStatusChanged, self._onRestoreUserInterfaceForPictureInPictureStop)
+            _pip = RCTPictureInPicture({ [weak self] in
+                self?._onPictureInPictureStatusChanged()
+            }, { [weak self] in
+                self?._onRestoreUserInterfaceForPictureInPictureStop()
+            })
        #endif

        NotificationCenter.default.addObserver(
@@ -193,6 +197,7 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
    deinit {
        NotificationCenter.default.removeObserver(self)
        self.removePlayerLayer()
+        _pip = nil
        _playerObserver.clearPlayer()
    }