Merge pull request #56 from isair/fix/playable-duration-edge-cases

Fix 'Invalid number value (NaN) in JSON write' crash
2015-06-17 22:24:37 -07:00 · 2015-06-17 22:24:37 -07:00 · bd755d88c4
commit bd755d88c4
parent 3ac8d2e74a 0927cee27b
1 changed files with 5 additions and 2 deletions
--- a/RCTVideo.m
+++ b/RCTVideo.m
@ -96,9 +96,12 @@ static NSString *const statusKeyPath = @"status";
        *stop = YES;
      }
    }];
-    return [NSNumber numberWithFloat:CMTimeGetSeconds(CMTimeRangeGetEnd(effectiveTimeRange))];
+    Float64 playableDuration = CMTimeGetSeconds(CMTimeRangeGetEnd(effectiveTimeRange));
+    if (playableDuration > 0) {
+      return [NSNumber numberWithFloat:playableDuration];
+    }
  }
-  return [NSNumber numberWithFloat:CMTimeGetSeconds(kCMTimeInvalid)];
+  return [NSNumber numberWithInteger:0];
 }

 - (void)stopProgressTimer