railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Removing the call to observeValueForKeyPath:ofObject:change:context: on super from RCTVideo.

Browse Source 
If the super class is not actually observing the key, the app will crash. Checking to see if
the super class responds to this selector doesn't solve this issue.

react-native-video github issue: https://github.com/react-native-community/react-native-video/issues/1515

Discussion about this particular problem: https://stackoverflow.com/questions/6574714/whats-wrong-with-this-observevalueforkeypathofobjectchangecontext-implement
This commit is contained in:
Nahuel Marisi 2019-08-20 09:37:49 +02:00
parent c29244bf89
commit 7a9081d5af
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ios/Video/RCTVideo.m
View File

@ -712,8 +712,6 @@ static int const RCTVideoUnset = -1;
return; return;
} }
} else if ([super respondsToSelector:@selector(observeValueForKeyPath:ofObject:change:context:)]) {
[super observeValueForKeyPath:keyPath ofObject:object change:change context:context];
} }
} }