From 7a9081d5afc2ef2b0ba0ee01d7d7912bcafa0cb5 Mon Sep 17 00:00:00 2001 From: Nahuel Marisi Date: Tue, 20 Aug 2019 09:37:49 +0200 Subject: [PATCH] Removing the call to observeValueForKeyPath:ofObject:change:context: on super from RCTVideo. If the super class is not actually observing the key, the app will crash. Checking to see if the super class responds to this selector doesn't solve this issue. react-native-video github issue: https://github.com/react-native-community/react-native-video/issues/1515 Discussion about this particular problem: https://stackoverflow.com/questions/6574714/whats-wrong-with-this-observevalueforkeypathofobjectchangecontext-implement --- ios/Video/RCTVideo.m | 2 -- 1 file changed, 2 deletions(-) diff --git a/ios/Video/RCTVideo.m b/ios/Video/RCTVideo.m index 4710afaa..98cb0737 100644 --- a/ios/Video/RCTVideo.m +++ b/ios/Video/RCTVideo.m @@ -712,8 +712,6 @@ static int const RCTVideoUnset = -1; return; } - } else if ([super respondsToSelector:@selector(observeValueForKeyPath:ofObject:change:context:)]) { - [super observeValueForKeyPath:keyPath ofObject:object change:change context:context]; } }