railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2721 from tironiigor/fix-onReadyForDisplay-not-called

Browse Source 
Fix onReadyForDisplay not being called on iOS
This commit is contained in:
Eran Hammer 2022-06-15 10:50:57 -07:00 committed by GitHub
commit 289b2df4d4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -36,6 +36,7 @@
- Fix volume reset issue in exoPlayer [#2371](https://github.com/react-native-video/react-native-video/pull/2371) - Fix volume reset issue in exoPlayer [#2371](https://github.com/react-native-video/react-native-video/pull/2371)
- Change WindowsTargetPlatformVersion to 10.0 [#2706](https://github.com/react-native-video/react-native-video/pull/2706) - Change WindowsTargetPlatformVersion to 10.0 [#2706](https://github.com/react-native-video/react-native-video/pull/2706)
- Fixed Android seeking bug [#2712](https://github.com/react-native-video/react-native-video/pull/2712) - Fixed Android seeking bug [#2712](https://github.com/react-native-video/react-native-video/pull/2712)
- Fixed `onReadyForDisplay` not being called [#2721](https://github.com/react-native-video/react-native-video/pull/2721)
### Version 5.2.0 ### Version 5.2.0

2
ios/Video/Features/RCTPlayerObserver.swift
View File

@ -64,7 +64,7 @@ class RCTPlayerObserver: NSObject {
removePlayerLayerObserver() removePlayerLayerObserver()
} }
didSet { didSet {
if playerLayer == nil { if playerLayer != nil {
addPlayerLayerObserver() addPlayerLayerObserver()
} }
} }