From e1574675b5e3ca7a32cac492fe5a64c0e087227f Mon Sep 17 00:00:00 2001 From: Igor Tironi Date: Tue, 14 Jun 2022 16:58:47 -0700 Subject: [PATCH 1/2] flipped playerLayer nil check to start observer --- ios/Video/Features/RCTPlayerObserver.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ios/Video/Features/RCTPlayerObserver.swift b/ios/Video/Features/RCTPlayerObserver.swift index 73f3754f..68fc56dd 100644 --- a/ios/Video/Features/RCTPlayerObserver.swift +++ b/ios/Video/Features/RCTPlayerObserver.swift @@ -64,7 +64,7 @@ class RCTPlayerObserver: NSObject { removePlayerLayerObserver() } didSet { - if playerLayer == nil { + if playerLayer != nil { addPlayerLayerObserver() } } From ab1f1c4024d83c4f9f038afa253f88a9570bb303 Mon Sep 17 00:00:00 2001 From: Igor Tironi Date: Tue, 14 Jun 2022 17:00:59 -0700 Subject: [PATCH 2/2] added changelog entry --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 36f9a78c..402b4032 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,6 +35,7 @@ - Fix volume reset issue in exoPlayer [#2371](https://github.com/react-native-video/react-native-video/pull/2371) - Change WindowsTargetPlatformVersion to 10.0 [#2706](https://github.com/react-native-video/react-native-video/pull/2706) - Fixed Android seeking bug [#2712](https://github.com/react-native-video/react-native-video/pull/2712) +- Fixed `onReadyForDisplay` not being called [#2721](https://github.com/react-native-video/react-native-video/pull/2721) ### Version 5.2.0