railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2720 from tironiigor/type-event-dispatcher-with-protocol

Browse Source 
Fix iOS build caused by type mismatch
This commit is contained in:
Eran Hammer 2022-06-20 21:53:57 -07:00 committed by GitHub
commit 054abcac8e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -42,6 +42,7 @@
- Change WindowsTargetPlatformVersion to 10.0 [#2706](https://github.com/react-native-video/react-native-video/pull/2706)
- Fixed Android seeking bug [#2712](https://github.com/react-native-video/react-native-video/pull/2712)
- Fixed `onReadyForDisplay` not being called [#2721](https://github.com/react-native-video/react-native-video/pull/2721)
- Fix type of `_eventDispatcher` on iOS target to match `bridge.eventDispatcher()` [#2720](https://github.com/react-native-video/react-native-video/pull/2720)
### Version 5.2.0

4
ios/Video/RCTVideo.swift
View File

@ -21,7 +21,7 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
private var _localSourceEncryptionKeyScheme:String?
/* Required to publish events */
private var _eventDispatcher:RCTEventDispatcher?
private var _eventDispatcher:RCTEventDispatcherProtocol?
private var _videoLoadStarted:Bool = false
private var _pendingSeek:Bool = false
@ -95,7 +95,7 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
@objc var onRestoreUserInterfaceForPictureInPictureStop: RCTDirectEventBlock?
@objc var onGetLicense: RCTDirectEventBlock?
init(eventDispatcher:RCTEventDispatcher!) {
init(eventDispatcher:RCTEventDispatcherProtocol!) {
super.init(frame: CGRect(x: 0, y: 0, width: 100, height: 100))
_eventDispatcher = eventDispatcher