From 537d36cf60f2681079fcc9ddf9bdeb39c95cfc58 Mon Sep 17 00:00:00 2001 From: Igor Tironi Date: Tue, 14 Jun 2022 15:50:22 -0700 Subject: [PATCH 1/3] type _eventDispatcher as RCTEventDispatcherProtocol --- ios/Video/RCTVideo.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ios/Video/RCTVideo.swift b/ios/Video/RCTVideo.swift index 76701229..fb5270ab 100644 --- a/ios/Video/RCTVideo.swift +++ b/ios/Video/RCTVideo.swift @@ -21,7 +21,7 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH private var _localSourceEncryptionKeyScheme:String? /* Required to publish events */ - private var _eventDispatcher:RCTEventDispatcher? + private var _eventDispatcher:RCTEventDispatcherProtocol? private var _videoLoadStarted:Bool = false private var _pendingSeek:Bool = false @@ -95,7 +95,7 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH @objc var onRestoreUserInterfaceForPictureInPictureStop: RCTDirectEventBlock? @objc var onGetLicense: RCTDirectEventBlock? - init(eventDispatcher:RCTEventDispatcher!) { + init(eventDispatcher:RCTEventDispatcherProtocol!) { super.init(frame: CGRect(x: 0, y: 0, width: 100, height: 100)) _eventDispatcher = eventDispatcher From ecab687cb205de788c19168ad58e484a3c4cc685 Mon Sep 17 00:00:00 2001 From: Igor Tironi Date: Tue, 14 Jun 2022 15:51:19 -0700 Subject: [PATCH 2/3] update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 36f9a78c..d251364e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,6 +35,7 @@ - Fix volume reset issue in exoPlayer [#2371](https://github.com/react-native-video/react-native-video/pull/2371) - Change WindowsTargetPlatformVersion to 10.0 [#2706](https://github.com/react-native-video/react-native-video/pull/2706) - Fixed Android seeking bug [#2712](https://github.com/react-native-video/react-native-video/pull/2712) +- Fix type of `_eventDispatcher` on iOS target to match `bridge.eventDispatcher()` ### Version 5.2.0 From e5d81bf1930de2321ed9c81043fce82aeeab254e Mon Sep 17 00:00:00 2001 From: Igor Tironi Date: Tue, 14 Jun 2022 16:05:42 -0700 Subject: [PATCH 3/3] include PR link to changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d251364e..c7cba52c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,7 +35,7 @@ - Fix volume reset issue in exoPlayer [#2371](https://github.com/react-native-video/react-native-video/pull/2371) - Change WindowsTargetPlatformVersion to 10.0 [#2706](https://github.com/react-native-video/react-native-video/pull/2706) - Fixed Android seeking bug [#2712](https://github.com/react-native-video/react-native-video/pull/2712) -- Fix type of `_eventDispatcher` on iOS target to match `bridge.eventDispatcher()` +- Fix type of `_eventDispatcher` on iOS target to match `bridge.eventDispatcher()` [#2720](https://github.com/react-native-video/react-native-video/pull/2720) ### Version 5.2.0