Create shot fragment #62

Closed
kkathuang wants to merge 0 commits from kat/create-shot-fragment into master
Owner
No description provided.
kkathuang added 1 commit 2024-09-30 17:09:34 -06:00
Create shot fragment
Some checks failed
Tests / Tests (pull_request) Failing after 4s
1a4b676635
colonelpanic reviewed 2024-09-30 17:39:19 -06:00
@ -141,1 +141,4 @@
}
# shot.gql
fragment ShotFragment on ShotGQL {
Owner

calling this ShotFragment makes it so that we get a datatype ShotFragmentFragment which is annoying.

I might call this something like CompleteShot

or ShotWithAllFeatures

calling this ShotFragment makes it so that we get a datatype ShotFragmentFragment which is annoying. I might call this something like CompleteShot or ShotWithAllFeatures
colonelpanic reviewed 2024-09-30 17:39:32 -06:00
@ -188,2 +204,2 @@
intendedPocketType @include(if: $includeIntendedPocketType)
}
...ShotFragment
# Since the fragment already includes all necessary fields,
Owner

remove

remove
kkathuang added 1 commit 2024-09-30 21:15:50 -06:00
Delete unused varibles
Some checks failed
Tests / Tests (pull_request) Failing after 3s
ae16381094
kkathuang force-pushed kat/create-shot-fragment from ae16381094 to 301c017d5e 2024-10-01 15:38:16 -06:00 Compare
kkathuang closed this pull request 2024-10-01 17:46:45 -06:00
All checks were successful
Tests / Tests (pull_request) Successful in 10s
Required
Details

Pull request closed

Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: railbird/railbird-gql#62
No description provided.