railbird/railbird-gql
10
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Create shot fragment #62

Closed
kkathuang wants to merge 0 commits from kat/create-shot-fragment into master
pull from: kat/create-shot-fragment
merge into: railbird:master
Conversation 2 Commits - Files Changed - +111 -114
kkathuang commented 2024-09-30 23:09:33 +00:00
Owner
Copy Link
No description provided.
kkathuang added 1 commit 2024-09-30 23:09:34 +00:00
Create shot fragment
Some checks failed
Tests / Tests (pull_request) Failing after 4s
Details
1a4b676635
colonelpanic reviewed 2024-09-30 23:39:19 +00:00
src/operations/shots.gql
@@ -141,1 +141,4 @@
}
# shot.gql
fragment ShotFragment on ShotGQL {
colonelpanic commented 2024-09-30 23:39:19 +00:00
Owner
Copy Link

calling this ShotFragment makes it so that we get a datatype ShotFragmentFragment which is annoying.

I might call this something like CompleteShot

or ShotWithAllFeatures

calling this ShotFragment makes it so that we get a datatype ShotFragmentFragment which is annoying. I might call this something like CompleteShot or ShotWithAllFeatures
colonelpanic reviewed 2024-09-30 23:39:32 +00:00
src/operations/shots.gql Outdated
@@ -188,2 +204,2 @@
intendedPocketType @include(if: $includeIntendedPocketType)
}
...ShotFragment
# Since the fragment already includes all necessary fields,
colonelpanic commented 2024-09-30 23:39:32 +00:00
Owner
Copy Link

remove

remove
kkathuang force-pushed kat/create-shot-fragment from ae16381094 to 301c017d5e 2024-10-01 21:38:16 +00:00 Compare
kkathuang closed this pull request 2024-10-01 23:46:45 +00:00
All checks were successful
Tests / Tests (pull_request) Successful in 10s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alexmalison bcorner colonelpanic countablecloud dean kkathuang loewy micah_weitzman wgester
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: railbird/railbird-gql#62
No description provided.
Delete Branch "kat/create-shot-fragment"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?