Merge pull request 'Rename Session Coach feedback enums' (#323) from loewy/session-coach-feedback-enums into master

Reviewed-on: #323

src/index.tsx

@@ -3795,10 +3795,10 @@ export type SessionCoachFeedbackGql = {
 };
 
 export enum SessionCoachFeedbackResponseEnum {
-  AlreadyWorkingOnThis = "ALREADY_WORKING_ON_THIS",
   Helpful = "HELPFUL",
   NotEnoughEvidence = "NOT_ENOUGH_EVIDENCE",
-  WrongFocus = "WRONG_FOCUS",
+  NotInsightful = "NOT_INSIGHTFUL",
+  NotRelevant = "NOT_RELEVANT",
 }
 
 export type SessionCoachGql = {
@@ -3969,6 +3969,7 @@ export type ShotProjectionGql = {
 
 export type ShotTableStateGql = {
   __typename?: "ShotTableStateGQL";
+  frameImage?: Maybe<Scalars["String"]["output"]>;
   frameIndex: Scalars["Int"]["output"];
   shotId: Scalars["Int"]["output"];
   tableState: TableStateGql;
@@ -7822,6 +7823,7 @@ export type GetShotTableStateQuery = {
     shotId: number;
     videoId: number;
     frameIndex: number;
+    frameImage?: string | null;
     tableState: {
       __typename?: "TableStateGQL";
       identifierToPosition: Array<Array<number>>;
@@ -16602,6 +16604,7 @@ export const GetShotTableStateDocument = gql`
       shotId
       videoId
       frameIndex
+      frameImage
       tableState {
         ...TableStateLayoutFields
       }

src/operations/shot_simulation.gql

@@ -44,9 +44,10 @@ fragment DetectionPocketPointFields on PocketPointsGQL {
 # positions. Boxes, pocket boxes, and source points share the crop's
 # coordinate space; the crop locates that space in the full frame.
 #
-# Only the photo query selects this. The live and shot queries read a
+# Only the photo query selects this. The shot query returns its source
-# frame out of a video the app never holds, so there is no image to
+# frame (frameImage) but positions there come from the stored homography,
-# overlay, and getLiveTableState is polled every five seconds.
+# so there are no fresh boxes to draw; the live query returns no image at
+# all and is polled every five seconds.
 fragment TableStateDetectionFields on TableStateGQL {
   identifierToBox {
     ...DetectionBoxFields
@@ -97,6 +98,9 @@ query GetShotTableState($shotId: Int!) {
     shotId
     videoId
     frameIndex
+    # The b64 JPEG frame the layout was detected in, so the client can show
+    # the shot's actual starting frame instead of the video's thumbnail.
+    frameImage
     tableState {
       ...TableStateLayoutFields
     }

src/schema.gql

@@ -250,11 +250,6 @@ input CreatePoolHallCameraInput {
   claimTermsText: String = null
 }
 
-input CreateShotShareLinkInput {
-  shotIds: [Int!]!
-  paddingSeconds: Float = null
-}
-
 input CreatePoolHallInput {
   name: String!
   address: String = null
@@ -1412,8 +1407,8 @@ type SessionCoachFeedbackGQL {
 
 enum SessionCoachFeedbackResponseEnum {
   HELPFUL
-  WRONG_FOCUS
+  NOT_RELEVANT
-  ALREADY_WORKING_ON_THIS
+  NOT_INSIGHTFUL
   NOT_ENOUGH_EVIDENCE
 }
 
@@ -1574,6 +1569,7 @@ type ShotTableStateGQL {
   videoId: Int!
   frameIndex: Int!
   tableState: TableStateGQL!
+  frameImage: String
 }
 
 input ShotsOrderingComponent @oneOf {
@@ -1967,11 +1963,6 @@ type UserSubscriptionStatusGQL {
   stripeSubscriptionId: String
 }
 
-type ShareLinkGQL {
-  slug: String!
-  url: String!
-}
-
 type VideoExportJobGQL {
   id: Int!
   videoId: Int!