Merge pull request 'Let shot filters select a single player within a video' (#322) from dean/filter-by-player-index into master

Reviewed-on: #322

src/operations/recorded_shots.gql

@@ -1,12 +1,19 @@
-# Lightweight two-step picker data for Shot Lab's video-first source: the
-# caller's recent videos (completed or still uploading), then that video's
-# shots. The stream fields hint at "actively updating" without gating.
-query GetShotLabVideos($userId: Int!, $limit: Int! = 25) {
+# Lightweight two-step picker data for Shot Lab's video-first source: recent
+# videos from the requested audience (mine, followed users, or public), then
+# that video's shots. The stream fields hint at "actively updating" without
+# gating.
+query GetShotLabVideos(
+  $feedInput: VideoFeedInputGQL!
+  $includePrivate: IncludePrivateEnum!
+  $limit: Int! = 25
+  $after: String = null
+) {
   getFeedVideos(
     limit: $limit
+    after: $after
     includeCallersVideos: false
-    includePrivate: MINE
-    feedInput: { userId: $userId }
+    includePrivate: $includePrivate
+    feedInput: $feedInput
   ) {
     videos {
       id
@@ -26,6 +33,10 @@ query GetShotLabVideos($userId: Int!, $limit: Int! = 25) {
         lastSegmentUploadedAt
       }
     }
+    pageInfo {
+      hasNextPage
+      endCursor
+    }
   }
 }
 

src/operations/session-coach.gql

@@ -14,6 +14,16 @@ query GetSessionCoach($videoId: Int!) {
     unknownOutcomeCount
     analyzedShotCount
     makePercentage
+    longestMakeStreak
+    recentBaseline {
+      sessionCount
+      attemptCount
+      madeCount
+      makePercentage
+    }
+    positiveCandidates {
+      ...SessionCoachCandidateFields
+    }
     primaryCandidate {
       ...SessionCoachCandidateFields
     }
@@ -26,6 +36,22 @@ query GetSessionCoach($videoId: Int!) {
   }
 }
 
+query GetSessionCoachGenerationStatus($videoId: Int!, $generationId: ID!) {
+  getSessionCoachGenerationStatus(
+    videoId: $videoId
+    generationId: $generationId
+  ) {
+    id
+    state
+    createdAt
+    updatedAt
+    startedAt
+    lastEnqueuedAt
+    enqueueCount
+    completedAt
+  }
+}
+
 mutation RequestSessionCoachGeneration($videoId: Int!) {
   requestSessionCoachGeneration(videoId: $videoId) {
     state
@@ -35,6 +61,21 @@ mutation RequestSessionCoachGeneration($videoId: Int!) {
   }
 }
 
+mutation SubmitSessionCoachFeedback(
+  $videoId: Int!
+  $generationId: ID!
+  $response: SessionCoachFeedbackResponseEnum!
+) {
+  submitSessionCoachFeedback(
+    videoId: $videoId
+    generationId: $generationId
+    response: $response
+  ) {
+    response
+    updatedAt
+  }
+}
+
 fragment SessionCoachCandidateFields on SessionCoachCandidateGQL {
   id
   rank
@@ -59,6 +100,10 @@ fragment SessionCoachCandidateFields on SessionCoachCandidateGQL {
     patternShotCount
     score
     rankReason
+    baselineSessionCount
+    baselineAttemptCount
+    baselineMadeCount
+    baselineMakePercentage
   }
 }
 
@@ -68,7 +113,13 @@ fragment SessionCoachGenerationFields on SessionCoachGenerationGQL {
   createdAt
   completedAt
   decision {
+    selectedPositiveCandidateId
+    positiveTitle
+    positiveBody
     selectedCandidateId
+    supportingCandidateIds
+    supportingShotIds
+    sessionSummary
     title
     body
     suggestedAction
@@ -95,5 +146,10 @@ fragment SessionCoachGenerationFields on SessionCoachGenerationGQL {
     startedAt
     lastEnqueuedAt
     abstentionReason
+    synthesisRationale
+  }
+  feedback {
+    response
+    updatedAt
   }
 }

src/operations/share_link.gql

@@ -0,0 +1,8 @@
+mutation CreateShotShareLink($shotIds: [Int!]!, $paddingSeconds: Float = null) {
+  createShotShareLink(
+    input: { shotIds: $shotIds, paddingSeconds: $paddingSeconds }
+  ) {
+    slug
+    url
+  }
+}

src/operations/shot_simulation.gql

@@ -1,3 +1,73 @@
+fragment TableStateLayoutFields on TableStateGQL {
+  identifierToPosition
+  identifierToColor {
+    hex
+  }
+}
+
+fragment DetectionBoxFields on BoundingBoxGQL {
+  left
+  top
+  width
+  height
+}
+
+fragment DetectionPocketPointFields on PocketPointsGQL {
+  topLeft {
+    x
+    y
+  }
+  topSide {
+    x
+    y
+  }
+  topRight {
+    x
+    y
+  }
+  bottomLeft {
+    x
+    y
+  }
+  bottomSide {
+    x
+    y
+  }
+  bottomRight {
+    x
+    y
+  }
+}
+
+# Everything needed to redraw a detection over the image it came from:
+# the detector's boxes plus the homography that turned them into plane
+# positions. Boxes, pocket boxes, and source points share the crop's
+# coordinate space; the crop locates that space in the full frame.
+#
+# Only the photo query selects this. The shot query returns its source
+# frame (frameImage) but positions there come from the stored homography,
+# so there are no fresh boxes to draw; the live query returns no image at
+# all and is polled every five seconds.
+fragment TableStateDetectionFields on TableStateGQL {
+  identifierToBox {
+    ...DetectionBoxFields
+  }
+  homography {
+    crop {
+      ...DetectionBoxFields
+    }
+    pockets {
+      ...DetectionBoxFields
+    }
+    sourcePoints {
+      ...DetectionPocketPointFields
+    }
+    destPoints {
+      ...DetectionPocketPointFields
+    }
+  }
+}
+
 query GetTableState(
   $b64Image: String!
   $tableSize: Float
@@ -8,10 +78,8 @@ query GetTableState(
     tableSize: $tableSize
     useHomography: $useHomography
   ) {
-    identifierToPosition
-    identifierToColor {
-      hex
-    }
+    ...TableStateLayoutFields
+    ...TableStateDetectionFields
   }
 }
 
@@ -20,10 +88,7 @@ query GetLiveTableState($videoId: Int!) {
     videoId
     frameIndex
     tableState {
-      identifierToPosition
-      identifierToColor {
-        hex
-      }
+      ...TableStateLayoutFields
     }
   }
 }
@@ -33,11 +98,11 @@ query GetShotTableState($shotId: Int!) {
     shotId
     videoId
     frameIndex
+    # The b64 JPEG frame the layout was detected in, so the client can show
+    # the shot's actual starting frame instead of the video's thumbnail.
+    frameImage
     tableState {
-      identifierToPosition
-      identifierToColor {
-        hex
-      }
+      ...TableStateLayoutFields
     }
   }
 }

src/operations/video_upload.gql

@@ -54,6 +54,51 @@ mutation GetUploadLink($videoId: Int!, $segmentIndex: Int!) {
   }
 }
 
+mutation GetUploadLinks($videoId: Int!, $segmentIndexes: [Int!]!) {
+  getUploadLinks(videoId: $videoId, segmentIndexes: $segmentIndexes) {
+    value {
+      ... on UploadLinkBatch {
+        links {
+          segmentIndex
+          uploadUrl
+          headers {
+            key
+            value
+          }
+        }
+        alreadyUploaded
+      }
+      ... on GetUploadLinkErrors {
+        error {
+          ... on MustHaveSetForUploadLinkErr {
+            resolution
+            framesPerSecond
+          }
+          ... on ProcessingFailedErr {
+            processing {
+              status
+              errors {
+                message
+              }
+            }
+          }
+          ... on StorageLimitExceededErr {
+            reason
+            tierName
+            retainedStorageUsedBytes
+            retainedStorageLimitBytes
+            remainingStorageBytes
+          }
+        }
+      }
+    }
+    stream {
+      id
+      uploadCompletionCursor
+    }
+  }
+}
+
 mutation GetHlsInitUploadLink($videoId: Int!) {
   getHlsInitUploadLink(videoId: $videoId) {
     value {

src/schema.gql

@@ -408,6 +408,7 @@ input FilterInput @oneOf {
   userId: [Int!]
   runId: [Int!]
   username: [String!]
+  playerIndex: [Int!]
   fargoRating: FloatRangeFilter
   make: [Boolean!]
   tags: [VideoTagInput!]
@@ -731,6 +732,11 @@ type Mutation {
     shotId: Int!
     fieldsToEdit: EditableShotFieldInputGQL!
   ): EditShotReturn!
+  submitSessionCoachFeedback(
+    videoId: Int!
+    generationId: ID!
+    response: SessionCoachFeedbackResponseEnum!
+  ): SessionCoachFeedbackGQL!
   requestSessionCoachGeneration(videoId: Int!): SessionCoachGQL!
   getProfileImageUploadLink(
     fileExt: String = ".png"
@@ -1071,6 +1077,10 @@ type Query {
     limit: Int! = 500
     countRespectsLimit: Boolean! = false
   ): GetRunsResult!
+  getSessionCoachGenerationStatus(
+    videoId: Int!
+    generationId: ID!
+  ): SessionCoachGenerationStatusGQL
   getSessionCoach(videoId: Int!): SessionCoachGQL!
   videoPlayerClusters(videoId: Int!): [PlayerClusterGQL!]!
   getShotAnnotationTypes(errorTypes: Boolean = false): [ShotAnnotationTypeGQL!]!
@@ -1390,6 +1400,18 @@ type SessionCoachEvidenceGQL {
   baselineMakePercentage: Float
 }
 
+type SessionCoachFeedbackGQL {
+  response: SessionCoachFeedbackResponseEnum!
+  updatedAt: DateTime!
+}
+
+enum SessionCoachFeedbackResponseEnum {
+  HELPFUL
+  WRONG_FOCUS
+  ALREADY_WORKING_ON_THIS
+  NOT_ENOUGH_EVIDENCE
+}
+
 type SessionCoachGQL {
   videoId: Int!
   processingId: Int
@@ -1441,6 +1463,7 @@ type SessionCoachGenerationGQL {
   completedAt: DateTime
   decision: SessionCoachDecisionGQL
   diagnostics: SessionCoachGenerationDiagnosticsGQL
+  feedback: SessionCoachFeedbackGQL
 }
 
 enum SessionCoachGenerationStateEnum {
@@ -1450,6 +1473,17 @@ enum SessionCoachGenerationStateEnum {
   FAILED
 }
 
+type SessionCoachGenerationStatusGQL {
+  id: ID!
+  state: SessionCoachGenerationStateEnum!
+  createdAt: DateTime!
+  updatedAt: DateTime!
+  startedAt: DateTime
+  lastEnqueuedAt: DateTime
+  enqueueCount: Int!
+  completedAt: DateTime
+}
+
 enum SessionCoachIneligibilityReasonEnum {
   MULTIPLAYER
 }
@@ -1535,6 +1569,7 @@ type ShotTableStateGQL {
   videoId: Int!
   frameIndex: Int!
   tableState: TableStateGQL!
+  frameImage: String
 }
 
 input ShotsOrderingComponent @oneOf {
@@ -1716,6 +1751,7 @@ type TableStateGQL {
   identifierToPosition: [[Float!]!]!
   homography: HomographyInfoGQL
   identifierToColor: [RGBColorGQL]!
+  identifierToBox: [BoundingBoxGQL!]!
 }
 
 type TagClassGQL {
@@ -1937,7 +1973,7 @@ type VideoExportJobGQL {
   shotIds: [Int!]
   runId: Int
   downloadUrl: String
-  fileSizeBytes: Int
+  fileSizeBytes: BigInt
   expiresAt: DateTime
   createdAt: DateTime
 }