wgester/dotfiles
1
0
Fork 0
forked from colonelpanic/dotfiles
Code Pull Requests Activity

Simplify let-around and let-advise-around

Browse Source 
This commit also removes the unnecessary "dynamic" versions of these
functions.
This commit is contained in:
Ivan Malison 2016-08-12 14:53:18 -07:00
parent 4aca24b3cf
commit 7e40e085e6
No known key found for this signature in database
GPG Key ID: 62530EFBE99DC2F8
1 changed files with 10 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
dotfiles/emacs.d/README.org
View File

@ -597,40 +597,17 @@ the ~:around~ keyword of advice-add.
*** Let Around *** Let Around
#+BEGIN_SRC emacs-lisp #+BEGIN_SRC emacs-lisp
(defmacro imalison:let-around-fn (orig-func &rest forms) (defmacro imalison:let-around-fn (orig-func &rest forms)
`(lambda (&rest args) (let* ((orig-interactive-form (interactive-form orig-func))
(let ,forms (docstring-form (format "Call `%s' with bindings: %s." orig-func forms))
(apply (quote ,orig-func) args)))) (additional-forms (list docstring-form)))
#+END_SRC (when orig-interactive-form
(push orig-interactive-form additional-forms))
`(lambda (&rest args)
,@additional-forms
(let ,forms
(apply (quote ,orig-func) args)))))
#+BEGIN_SRC emacs-lisp (imalison:named-builder imalison:let-around)
(defmacro imalison:let-around (new-function-name function-name &rest args)
(let* ((orig-interactive-form (interactive-form function-name))
(additional-forms
(when orig-interactive-form
(list
`(put (quote ,new-function-name) 'interactive-form
(quote ,orig-interactive-form))))))
`(progn
(defalias (quote ,new-function-name)
(imalison:let-around-fn ,function-name ,@args))
,@additional-forms)))
(put 'imalison:let-around 'lisp-indent-function 1)
#+END_SRC
**** Dynamically, using functions
#+BEGIN_SRC emacs-lisp
(defmacro imalison:dynamic-let-around-fn (orig-func &rest getters)
`(lambda (&rest args)
(let ,(cl-loop for pair in getters
collect `(,(car pair) (funcall (quote ,(cadr pair)))))
(apply ,orig-func args))))
(imalison:named-builder imalison:dynamic-let-around)
#+END_SRC
**** Interactive
#+BEGIN_SRC emacs-lisp
(defmacro imalison:let-around-interactive (name &rest args)
`(imalison:make-interactive ,name (imalison:let-around-fn ,@args)))
#+END_SRC #+END_SRC
*** Let Around Advice *** Let Around Advice
#+BEGIN_SRC emacs-lisp #+BEGIN_SRC emacs-lisp
@ -641,14 +618,6 @@ the ~:around~ keyword of advice-add.
(imalison:named-builder imalison:let-advise-around) (imalison:named-builder imalison:let-advise-around)
#+END_SRC #+END_SRC
**** Dynamically, using functions
#+BEGIN_SRC emacs-lisp
(defmacro imalison:dynamic-let-advise-around (name &rest getters)
`(defun ,name (orig-func &rest args)
(let ,(cl-loop for pair in getters
collect `(,(car pair) (funcall (quote ,(cadr pair)))))
(apply orig-func args))))
#+END_SRC
** Join Paths ** Join Paths
Works in the same way as os.path.join in python Works in the same way as os.path.join in python
#+BEGIN_SRC emacs-lisp #+BEGIN_SRC emacs-lisp