railbird/react-native-vision-camera
8
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
a54ff5782c
react-native-vision-camera/ios
History
Marc Rousavy 4a73cb96c1
fix: Fix view-not-found race condition in C++ code (#511) 
* Add custom `onViewReady` event to get layout

`componentDidMount` is async, so the native view _might_ not exist yet causing a race condition in the `setFrameProcessor` code.

This PR fixes this by calling `setFrameProcessor` only after the native view has actually mounted, and to ensure that I created a custom event that fires at that point.

* Update CameraView.swift
2021-10-11 18:27:23 +02:00
..
Extensions feat: frameProcessorFps="auto" and automatic performance suggestions (throttle or increase FPS) (#393) 2021-09-06 16:27:16 +02:00
Frame Processor fix: Fix divison by zero in Performance Sample collector (#416) 2021-09-08 17:18:12 +02:00
Parsers chore: Move to /mrousavy/ (#224) 2021-06-21 22:42:46 +02:00
React Utils Update JSIUtils.mm 2021-09-29 12:54:51 +02:00
VisionCamera.xcodeproj feat: frameProcessorFps="auto" and automatic performance suggestions (throttle or increase FPS) (#393) 2021-09-06 16:27:16 +02:00
.swift-version Run SwiftFormat in GH Action (#28) 2021-03-09 10:53:29 +01:00
.swiftformat Reformat (#116) 2021-03-31 15:43:29 +02:00
.swiftlint.yml Run SwiftFormat in GH Action (#28) 2021-03-09 10:53:29 +01:00
CameraBridge.h fix: Fix UI Thread race condition in setFrameProcessor(...) (#265) 2021-07-12 15:16:03 +02:00
CameraError.swift chore: Move to /mrousavy/ (#224) 2021-06-21 22:42:46 +02:00
CameraQueues.swift try: Improvements from WWDC 2021 1:1 workshop (#197) 2021-06-11 21:06:19 +02:00
CameraView.swift fix: Fix view-not-found race condition in C++ code (#511) 2021-10-11 18:27:23 +02:00
CameraView+AVAudioSession.swift feat: frameProcessorFps="auto" and automatic performance suggestions (throttle or increase FPS) (#393) 2021-09-06 16:27:16 +02:00
CameraView+AVCaptureSession.swift feat: frameProcessorFps="auto" and automatic performance suggestions (throttle or increase FPS) (#393) 2021-09-06 16:27:16 +02:00
CameraView+Focus.swift chore: Move to /mrousavy/ (#224) 2021-06-21 22:42:46 +02:00
CameraView+RecordVideo.swift fix: Fix divison by zero in Performance Sample collector (#416) 2021-09-08 17:18:12 +02:00
CameraView+TakePhoto.swift chore: Move to /mrousavy/ (#224) 2021-06-21 22:42:46 +02:00
CameraView+Zoom.swift chore: Move to /mrousavy/ (#224) 2021-06-21 22:42:46 +02:00
CameraViewManager.m fix: Fix view-not-found race condition in C++ code (#511) 2021-10-11 18:27:23 +02:00
CameraViewManager.swift feat: frameProcessorFps="auto" and automatic performance suggestions (throttle or increase FPS) (#393) 2021-09-06 16:27:16 +02:00
PhotoCaptureDelegate.swift chore: Move to /mrousavy/ (#224) 2021-06-21 22:42:46 +02:00
README.md Add "check-all" script 2021-03-09 12:19:18 +01:00
RecordingSession.swift feat: frameProcessorFps="auto" and automatic performance suggestions (throttle or increase FPS) (#393) 2021-09-06 16:27:16 +02:00

README.md

ios

This folder contains the iOS-platform-specific code for react-native-vision-camera.

Prerequesites

  1. Install Xcode tools 
    xcode-select --install
  2. Install need SwiftFormat and SwiftLint 
    brew install swiftformat swiftlint

Getting Started

It is recommended that you work on the code using the Example project (example/ios/VisionCameraExample.xcworkspace), since that always includes the React Native header files, plus you can easily test changes that way.

You can however still edit the library project here by opening VisionCamera.xcodeproj, this has the advantage of automatically formatting your Code (swiftformat) and showing you Linter errors (swiftlint) when trying to build (⌘+B).

Committing

Before committing, make sure that you're not violating the Swift or C++ codestyles. To do that, run the following command:

yarn check-ios

This will also try to automatically fix any errors by re-formatting the Swift code.