cd0b413706
Moves everything Camera related into `core/` / `Core/` so that it is better encapsulated from React Native.
Benefits:
1. Code is much better organized. Should be easier for collaborators now, and cleaner codebase for me.
2. Locking is fully atomically as you can now only configure the session through a lock/Mutex which is batch-overridable
* On iOS, this makes Camera startup time **MUCH** faster, I measured speedups from **1.5 seconds** to only **240 milliseconds** since we only lock/commit once! 🚀
* On Android, this fixes a few out-of-sync/concurrency issues like "Capture Request contains unconfigured Input/Output Surface!" since it is now a single lock-operation! 💪
3. It is easier to integrate VisionCamera outside of React Native (e.g. Native iOS Apps, NativeScript, Flutter, etc)
With this PR, VisionCamera V3 is up to **7x** faster than V2
53 lines
1.5 KiB
Swift
53 lines
1.5 KiB
Swift
//
|
|
// CameraView+RecordVideo.swift
|
|
// mrousavy
|
|
//
|
|
// Created by Marc Rousavy on 16.12.20.
|
|
// Copyright © 2020 mrousavy. All rights reserved.
|
|
//
|
|
|
|
import AVFoundation
|
|
|
|
// MARK: - CameraView + AVCaptureVideoDataOutputSampleBufferDelegate, AVCaptureAudioDataOutputSampleBufferDelegate
|
|
|
|
extension CameraView: AVCaptureVideoDataOutputSampleBufferDelegate, AVCaptureAudioDataOutputSampleBufferDelegate {
|
|
func startRecording(options: NSDictionary, callback jsCallback: @escaping RCTResponseSenderBlock) {
|
|
// Type-safety
|
|
let callback = Callback(jsCallback)
|
|
|
|
do {
|
|
let options = try RecordVideoOptions(fromJSValue: options)
|
|
|
|
// Start Recording with success and error callbacks
|
|
cameraSession.startRecording(
|
|
options: options,
|
|
onVideoRecorded: { video in
|
|
callback.resolve(video.toJSValue())
|
|
},
|
|
onError: { error in
|
|
callback.reject(error: error)
|
|
}
|
|
)
|
|
} catch {
|
|
// Some error occured while initializing VideoSettings
|
|
if let error = error as? CameraError {
|
|
callback.reject(error: error)
|
|
} else {
|
|
callback.reject(error: .capture(.unknown(message: error.localizedDescription)), cause: error as NSError)
|
|
}
|
|
}
|
|
}
|
|
|
|
func stopRecording(promise: Promise) {
|
|
cameraSession.stopRecording(promise: promise)
|
|
}
|
|
|
|
func pauseRecording(promise: Promise) {
|
|
cameraSession.pauseRecording(promise: promise)
|
|
}
|
|
|
|
func resumeRecording(promise: Promise) {
|
|
cameraSession.resumeRecording(promise: promise)
|
|
}
|
|
}
|