railbird/react-native-vision-camera
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pass filePath to RecordingSession #3

Merged
colonelpanic merged 1 commits from loewy/store-video-internally-with-video-id into main 2024-03-12 07:21:18 +00:00
Conversation 3 Commits 1 Files Changed 5 +414 -416
loewy commented 2024-03-12 06:55:26 +00:00
Member
Copy Link

-- filePath: String added, location of which is where chunks are stored until deleted
-- filePath is constructed in react-native code and passed with startRecording

-- `filePath: String` added, location of which is where chunks are stored until deleted -- filePath is constructed in react-native code and passed with `startRecording`
loewy added 1 commit 2024-03-12 06:55:27 +00:00
take internal storage filePath for RecordingSession, tested 489171f6f3
loewy changed title from WIP: pass filePath to RecordingSession to pass filePath to RecordingSession 2024-03-12 06:57:56 +00:00
colonelpanic reviewed 2024-03-12 07:06:59 +00:00
package/src/Camera.tsx
@@ -180,0 +173,4 @@
* }, 5000)
* ```
*/
public startRecording(options: RecordVideoOptions, filePath: string): void {
colonelpanic commented 2024-03-12 07:06:59 +00:00
Owner
Copy Link

why did this whitespace change?

why did this whitespace change?
colonelpanic reviewed 2024-03-12 07:07:08 +00:00
package/src/Camera.tsx
@@ -215,0 +207,4 @@
}
try {
// TODO: Use TurboModules to make this awaitable.
CameraModule.startRecording(this.handle, nativeOptions, filePath, onRecordCallback)
colonelpanic commented 2024-03-12 07:07:08 +00:00
Owner
Copy Link

hmm this whitespace too

hmm this whitespace too
loewy commented 2024-03-12 07:14:22 +00:00
Author
Member
Copy Link

i think when we first pushed up this repo it was using tab size 4, when i made my changes the prettier config was overriding on save and switching to tab space 2

the weird thing is it didn't show up as a change until i committed the code.

i think when we first pushed up this repo it was using tab size 4, when i made my changes the prettier config was overriding on save and switching to tab space 2 the weird thing is it didn't show up as a change until i committed the code.
colonelpanic commented 2024-03-12 07:21:12 +00:00
Owner
Copy Link

alright. i dont care that much in this repo. lets just merge

alright. i dont care that much in this repo. lets just merge
colonelpanic approved these changes 2024-03-12 07:07:10 +00:00
colonelpanic merged commit 952e4a93e1 into main 2024-03-12 07:21:18 +00:00
colonelpanic deleted branch loewy/store-video-internally-with-video-id 2024-03-12 07:21:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
colonelpanic
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
alexmalison bcorner colonelpanic countablecloud dean kkathuang loewy micah_weitzman wgester
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: railbird/react-native-vision-camera#3
No description provided.
Delete Branch "loewy/store-video-internally-with-video-id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?