pass filePath to RecordingSession #3

Merged
colonelpanic merged 1 commits from loewy/store-video-internally-with-video-id into main 2024-03-12 07:21:18 +00:00
Member

-- filePath: String added, location of which is where chunks are stored until deleted
-- filePath is constructed in react-native code and passed with startRecording

-- `filePath: String` added, location of which is where chunks are stored until deleted -- filePath is constructed in react-native code and passed with `startRecording`
loewy added 1 commit 2024-03-12 06:55:27 +00:00
loewy changed title from WIP: pass filePath to RecordingSession to pass filePath to RecordingSession 2024-03-12 06:57:56 +00:00
colonelpanic reviewed 2024-03-12 07:06:59 +00:00
@@ -180,0 +173,4 @@
* }, 5000)
* ```
*/
public startRecording(options: RecordVideoOptions, filePath: string): void {
Owner

why did this whitespace change?

why did this whitespace change?
colonelpanic reviewed 2024-03-12 07:07:08 +00:00
@@ -215,0 +207,4 @@
}
try {
// TODO: Use TurboModules to make this awaitable.
CameraModule.startRecording(this.handle, nativeOptions, filePath, onRecordCallback)
Owner

hmm this whitespace too

hmm this whitespace too
Author
Member

i think when we first pushed up this repo it was using tab size 4, when i made my changes the prettier config was overriding on save and switching to tab space 2

the weird thing is it didn't show up as a change until i committed the code.

i think when we first pushed up this repo it was using tab size 4, when i made my changes the prettier config was overriding on save and switching to tab space 2 the weird thing is it didn't show up as a change until i committed the code.
Owner

alright. i dont care that much in this repo. lets just merge

alright. i dont care that much in this repo. lets just merge
colonelpanic approved these changes 2024-03-12 07:07:10 +00:00
colonelpanic merged commit 952e4a93e1 into main 2024-03-12 07:21:18 +00:00
colonelpanic deleted branch loewy/store-video-internally-with-video-id 2024-03-12 07:21:18 +00:00
Sign in to join this conversation.
No Reviewers
No Label
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: railbird/react-native-vision-camera#3
No description provided.