From f6b7163660679599e48d1b75ab444ba8b5564809 Mon Sep 17 00:00:00 2001 From: Marc Rousavy Date: Fri, 16 Feb 2024 18:01:52 +0100 Subject: [PATCH] chore: Fix some C++ compiler warnings (#2576) * chore: Fix some C++ compiler warnings * Update MutableJByteBuffer.h * Update MutableJByteBuffer.h * Remove noexcept * Explicit --- package/android/src/main/cpp/MutableJByteBuffer.cpp | 2 +- .../src/main/cpp/frameprocessor/java-bindings/JSharedArray.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package/android/src/main/cpp/MutableJByteBuffer.cpp b/package/android/src/main/cpp/MutableJByteBuffer.cpp index b4d5695..e472da3 100644 --- a/package/android/src/main/cpp/MutableJByteBuffer.cpp +++ b/package/android/src/main/cpp/MutableJByteBuffer.cpp @@ -14,7 +14,7 @@ MutableJByteBuffer::MutableJByteBuffer(jni::alias_ref byteBuff _byteBuffer = jni::make_global(byteBuffer); } -MutableJByteBuffer::~MutableJByteBuffer() noexcept { +MutableJByteBuffer::~MutableJByteBuffer() { // Hermes GC might destroy HostObjects on an arbitrary Thread which might not be // connected to the JNI environment. To make sure fbjni can properly destroy // the Java method, we connect to a JNI environment first. diff --git a/package/android/src/main/cpp/frameprocessor/java-bindings/JSharedArray.cpp b/package/android/src/main/cpp/frameprocessor/java-bindings/JSharedArray.cpp index 474d0dd..46f94f8 100644 --- a/package/android/src/main/cpp/frameprocessor/java-bindings/JSharedArray.cpp +++ b/package/android/src/main/cpp/frameprocessor/java-bindings/JSharedArray.cpp @@ -34,7 +34,7 @@ JSharedArray::JSharedArray(const jni::alias_ref& javaThis, const #else jsi::Runtime& runtime = *proxy->cthis()->getJSRuntime(); #endif - __android_log_print(ANDROID_LOG_INFO, TAG, "Wrapping Java ByteBuffer with size %i...", byteBuffer->getDirectSize()); + __android_log_print(ANDROID_LOG_INFO, TAG, "Wrapping Java ByteBuffer with size %zu...", byteBuffer->getDirectSize()); _byteBuffer = jni::make_global(byteBuffer); _size = _byteBuffer->getDirectSize();