railbird/react-native-vision-camera
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Fix videoCodec being parsed wrong on Android

Browse Source
This commit is contained in:
Marc Rousavy 2023-11-28 20:23:28 +01:00
parent 980961d76f
commit edb415e913
No known key found for this signature in database
GPG Key ID: 83BEF0F19E8F5321
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package/android/src/main/java/com/mrousavy/camera/types/RecordVideoOptions.kt
View File

@ -17,7 +17,7 @@ class RecordVideoOptions(map: ReadableMap) {
flash = Flash.fromUnionValue(map.getString("flash")) flash = Flash.fromUnionValue(map.getString("flash"))
} }
if (map.hasKey("videoCodec")) { if (map.hasKey("videoCodec")) {
videoCodec = VideoCodec.fromUnionValue(map.getString("fileType")) videoCodec = VideoCodec.fromUnionValue(map.getString("videoCodec"))
} }
if (map.hasKey("videoBitRateOverride")) { if (map.hasKey("videoBitRateOverride")) {
videoBitRateOverride = map.getDouble("videoBitRateOverride") videoBitRateOverride = map.getDouble("videoBitRateOverride")

2
package/ios/Core/RecordingSession.swift
View File

@ -154,7 +154,7 @@ class RecordingSession {
ReactLogger.log(level: .info, message: "Started RecordingSession at time: \(currentTime.seconds)") ReactLogger.log(level: .info, message: "Started RecordingSession at time: \(currentTime.seconds)")
if audioWriter == nil { if audioWriter == nil {
// Audio was enabled, mark the Audio track as finished so we won't wait for it. // Audio was disabled, mark the Audio track as finished so we won't wait for it.
hasWrittenLastAudioFrame = true hasWrittenLastAudioFrame = true
} }
} }