From eb57b3877cc4a23ddc4a1fb0c0c08bb8dfe3bb3a Mon Sep 17 00:00:00 2001 From: Marc Rousavy Date: Tue, 20 Feb 2024 20:34:34 +0100 Subject: [PATCH] chore: Update actions --- .github/workflows/build-android.yml | 14 ++++---------- package/scripts/clang-format.sh | 3 ++- package/scripts/ktlint.sh | 3 ++- package/scripts/swiftformat.sh | 3 ++- package/scripts/swiftlint.sh | 3 ++- 5 files changed, 12 insertions(+), 14 deletions(-) diff --git a/.github/workflows/build-android.yml b/.github/workflows/build-android.yml index 7bc9ecb..e6d39ea 100644 --- a/.github/workflows/build-android.yml +++ b/.github/workflows/build-android.yml @@ -30,11 +30,11 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Setup JDK 11 + - name: Setup JDK 17 uses: actions/setup-java@v4 with: distribution: 'zulu' - java-version: 11 + java-version: 17 java-package: jdk - name: Get yarn cache directory path @@ -64,12 +64,6 @@ jobs: ${{ runner.os }}-gradle- - name: Run Gradle Build for example/android/ run: cd example/android && ./gradlew assembleDebug --build-cache && cd ../.. - - name: Upload .apk to GitHub - uses: actions/upload-artifact@v4 - with: - name: VisionCamera Example (.apk) - path: package/example/android/app/build/outputs/apk/debug/app-debug.apk - if-no-files-found: error build-no-frame-processors: name: Build Android Example App (without Frame Processors) @@ -80,11 +74,11 @@ jobs: steps: - uses: actions/checkout@v4 - - name: Setup JDK 11 + - name: Setup JDK 17 uses: actions/setup-java@v4 with: distribution: 'zulu' - java-version: 11 + java-version: 17 java-package: jdk - name: Get yarn cache directory path diff --git a/package/scripts/clang-format.sh b/package/scripts/clang-format.sh index 9c98c17..1d6cea4 100755 --- a/package/scripts/clang-format.sh +++ b/package/scripts/clang-format.sh @@ -5,5 +5,6 @@ if which clang-format >/dev/null; then clang-format -style=file:./cpp/.clang-format -i "$file" done else - echo "warning: clang-format not installed, install with 'brew install clang-format' (or manually from https://clang.llvm.org/docs/ClangFormat.html)" + echo "error: clang-format not installed, install with 'brew install clang-format' (or manually from https://clang.llvm.org/docs/ClangFormat.html)" + exit 1 fi diff --git a/package/scripts/ktlint.sh b/package/scripts/ktlint.sh index 3236451..7a8a263 100755 --- a/package/scripts/ktlint.sh +++ b/package/scripts/ktlint.sh @@ -3,5 +3,6 @@ if which ktlint >/dev/null; then cd android && ktlint --color --relative --editorconfig=./.editorconfig -F ./**/*.kt* else - echo "warning: KTLint not installed, install with 'brew install ktlint' (or manually from https://github.com/pinterest/ktlint)" + echo "error: KTLint not installed, install with 'brew install ktlint' (or manually from https://github.com/pinterest/ktlint)" + exit 1 fi diff --git a/package/scripts/swiftformat.sh b/package/scripts/swiftformat.sh index a7b628f..a06751d 100755 --- a/package/scripts/swiftformat.sh +++ b/package/scripts/swiftformat.sh @@ -3,5 +3,6 @@ if which swiftformat >/dev/null; then cd ios && swiftformat --quiet . else - echo "warning: SwiftFormat not installed, install with 'brew install swiftformat' (or manually from https://github.com/nicklockwood/SwiftFormat)" + echo "error: SwiftFormat not installed, install with 'brew install swiftformat' (or manually from https://github.com/nicklockwood/SwiftFormat)" + exit 1 fi diff --git a/package/scripts/swiftlint.sh b/package/scripts/swiftlint.sh index e355098..42efed7 100755 --- a/package/scripts/swiftlint.sh +++ b/package/scripts/swiftlint.sh @@ -3,5 +3,6 @@ if which swiftlint >/dev/null; then cd ios && swiftlint --quiet --fix && swiftlint --quiet else - echo "warning: SwiftLint not installed, install with 'brew install swiftlint' (or manually from https://github.com/realm/SwiftLint)" + echo "error: SwiftLint not installed, install with 'brew install swiftlint' (or manually from https://github.com/realm/SwiftLint)" + exit 1 fi