From c6ccae0cf2a2478b3a8740de471b85c5f1363d3a Mon Sep 17 00:00:00 2001 From: Marc Rousavy Date: Thu, 25 Feb 2021 14:07:46 +0100 Subject: [PATCH] SwiftLint: Fix force_cast --- ios/CameraView.swift | 1 + ios/CameraViewManager.swift | 25 +++++++++++-------------- 2 files changed, 12 insertions(+), 14 deletions(-) diff --git a/ios/CameraView.swift b/ios/CameraView.swift index 0d317a5..b08bd73 100644 --- a/ios/CameraView.swift +++ b/ios/CameraView.swift @@ -92,6 +92,7 @@ final class CameraView: UIView { /// Convenience wrapper to get layer as its statically known type. var videoPreviewLayer: AVCaptureVideoPreviewLayer { + // swiftlint:disable force_cast return layer as! AVCaptureVideoPreviewLayer } diff --git a/ios/CameraViewManager.swift b/ios/CameraViewManager.swift index 9bc7363..0e3a4f4 100644 --- a/ios/CameraViewManager.swift +++ b/ios/CameraViewManager.swift @@ -24,28 +24,27 @@ final class CameraViewManager: RCTViewManager { return DispatchQueue.main } + private func getCameraView(withTag tag: NSNumber) -> CameraView { + // swiftlint:disable force_cast + return bridge.uiManager.view(forReactTag: node) as! CameraView + } + // pragma MARK: Exported Functions @objc final func startRecording(_ node: NSNumber, options: NSDictionary, onRecordCallback: @escaping RCTResponseSenderBlock) { - let component = bridge.uiManager.view( - forReactTag: node - ) as! CameraView + let component = getCameraView(withTag: node) component.startRecording(options: options, callback: onRecordCallback) } @objc final func stopRecording(_ node: NSNumber, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) { - let component = bridge.uiManager.view( - forReactTag: node - ) as! CameraView + let component = getCameraView(withTag: node) component.stopRecording(promise: Promise(resolver: resolve, rejecter: reject)) } @objc final func takePhoto(_ node: NSNumber, options: NSDictionary, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) { - let component = bridge.uiManager.view( - forReactTag: node - ) as! CameraView + let component = getCameraView(withTag: node) component.takePhoto(options: options, promise: Promise(resolver: resolve, rejecter: reject)) } @@ -55,16 +54,14 @@ final class CameraViewManager: RCTViewManager { guard let x = point["x"] as? NSNumber, let y = point["y"] as? NSNumber else { return promise.reject(error: .parameter(.invalid(unionName: "point", receivedValue: point.description))) } - let component = bridge.uiManager.view( - forReactTag: node - ) as! CameraView + let component = getCameraView(withTag: node) component.focus(point: CGPoint(x: x.doubleValue, y: y.doubleValue), promise: promise) } @objc final func getAvailableVideoCodecs(_ node: NSNumber, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) { withPromise(resolve: resolve, reject: reject) { - let component = self.bridge.uiManager.view(forReactTag: node) as! CameraView + let component = getCameraView(withTag: node) guard let movieOutput = component.movieOutput else { throw CameraError.session(SessionError.cameraNotReady) } @@ -75,7 +72,7 @@ final class CameraViewManager: RCTViewManager { @objc final func getAvailablePhotoCodecs(_ node: NSNumber, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) { withPromise(resolve: resolve, reject: reject) { - let component = self.bridge.uiManager.view(forReactTag: node) as! CameraView + let component = getCameraView(withTag: node) guard let photoOutput = component.photoOutput else { throw CameraError.session(SessionError.cameraNotReady) }