railbird/react-native-vision-camera
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Remove exposure TODOs (#2177)

Browse Source 
* fix: Remove exposure TODOs

* fix: Make `exposure` a Double
This commit is contained in:
Marc Rousavy 2023-11-19 15:38:36 +01:00 committed by GitHub
parent ef58d13b87
commit 95a309808e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package/android/src/main/java/com/mrousavy/camera/CameraView.kt
View File

@ -78,7 +78,7 @@ class CameraView(context: Context) :
var isActive = false var isActive = false
var torch: Torch = Torch.OFF var torch: Torch = Torch.OFF
var zoom: Float = 1f // in "factor" var zoom: Float = 1f // in "factor"
var exposure: Float = 1f // TODO: Implement exposure bias var exposure: Double = 1.0
var orientation: Orientation = Orientation.PORTRAIT var orientation: Orientation = Orientation.PORTRAIT
var enableZoomGesture: Boolean = false var enableZoomGesture: Boolean = false
set(value) { set(value) {

2
package/android/src/main/java/com/mrousavy/camera/CameraViewManager.kt
View File

@ -145,7 +145,7 @@ class CameraViewManager : ViewGroupManager<CameraView>() {
@ReactProp(name = "exposure") @ReactProp(name = "exposure")
fun setExposure(view: CameraView, exposure: Double) { fun setExposure(view: CameraView, exposure: Double) {
view.exposure = exposure.toFloat() view.exposure = exposure
} }
@ReactProp(name = "orientation") @ReactProp(name = "orientation")

2
package/android/src/main/java/com/mrousavy/camera/core/CameraConfiguration.kt
View File

@ -33,7 +33,7 @@ data class CameraConfiguration(
var enableLowLightBoost: Boolean = false, var enableLowLightBoost: Boolean = false,
var torch: Torch = Torch.OFF, var torch: Torch = Torch.OFF,
var videoStabilizationMode: VideoStabilizationMode = VideoStabilizationMode.OFF, var videoStabilizationMode: VideoStabilizationMode = VideoStabilizationMode.OFF,
var exposure: Float? = null, var exposure: Double? = null,
// Zoom // Zoom
var zoom: Float = 1f, var zoom: Float = 1f,

1
package/android/src/main/java/com/mrousavy/camera/core/CameraDeviceDetails.kt
View File

@ -177,7 +177,6 @@ class CameraDeviceDetails(private val cameraManager: CameraManager, private val
map.putInt("videoWidth", videoSize.width) map.putInt("videoWidth", videoSize.width)
map.putInt("minISO", isoRange.lower) map.putInt("minISO", isoRange.lower)
map.putInt("maxISO", isoRange.upper) map.putInt("maxISO", isoRange.upper)
// TODO: Implement minExposureBias
map.putDouble("minExposure", exposureRange.lower.toDouble() / exposureStep.toDouble()) map.putDouble("minExposure", exposureRange.lower.toDouble() / exposureStep.toDouble())
map.putDouble("maxExposure", exposureRange.upper.toDouble() / exposureStep.toDouble()) map.putDouble("maxExposure", exposureRange.upper.toDouble() / exposureStep.toDouble())
map.putInt("minFps", fpsRange.lower) map.putInt("minFps", fpsRange.lower)

1
package/android/src/main/java/com/mrousavy/camera/core/CameraSession.kt
View File

@ -435,6 +435,7 @@ class CameraSession(private val context: Context, private val cameraManager: Cam
} }
// Set Exposure Bias // Set Exposure Bias
// TODO: Check if that exposure value is even supported
val exposure = config.exposure?.toInt() val exposure = config.exposure?.toInt()
if (exposure != null) { if (exposure != null) {
captureRequest.set(CaptureRequest.CONTROL_AE_EXPOSURE_COMPENSATION, exposure) captureRequest.set(CaptureRequest.CONTROL_AE_EXPOSURE_COMPENSATION, exposure)