fix: Fix close
being called on a collected reference (enforce alias_ref
) (#379)
* fix: Fix `close` being called on a collected reference (enforce `alias_ref`) * Remove `~FrameHostObject` on iOS too
This commit is contained in:
@@ -17,7 +17,6 @@ using namespace facebook;
|
||||
class JSI_EXPORT FrameHostObject: public jsi::HostObject {
|
||||
public:
|
||||
explicit FrameHostObject(Frame* frame): frame(frame) {}
|
||||
~FrameHostObject();
|
||||
|
||||
public:
|
||||
jsi::Value get(jsi::Runtime&, const jsi::PropNameID& name) override;
|
||||
|
@@ -89,10 +89,6 @@ void FrameHostObject::assertIsFrameStrong(jsi::Runtime &runtime, const std::stri
|
||||
}
|
||||
}
|
||||
|
||||
FrameHostObject::~FrameHostObject() {
|
||||
close();
|
||||
}
|
||||
|
||||
void FrameHostObject::close() {
|
||||
if (frame != nil) {
|
||||
CMSampleBufferInvalidate(frame.buffer);
|
||||
|
Reference in New Issue
Block a user