railbird/react-native-vision-camera
10
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Fix close being called on a collected reference (enforce alias_ref) (#379)

Browse Source 
* fix: Fix `close` being called on a collected reference (enforce `alias_ref`)

* Remove `~FrameHostObject` on iOS too
This commit is contained in:
Marc Rousavy
2021-08-20 16:05:02 +02:00
committed by GitHub
parent 97c20d96ae
commit 90f2a1ef7d
7 changed files with 5 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
android/src/main/cpp/java-bindings/JImageProxyHostObject.cpp
View File

@@ -77,15 +77,9 @@ void JImageProxyHostObject::assertIsFrameStrong(jsi::Runtime& runtime, const std
}
}
JImageProxyHostObject::~JImageProxyHostObject() {
this->close();
}
void JImageProxyHostObject::close() {
if (this->frame) {
this->frame->close();
this->frame.release();
}
}

5
android/src/main/cpp/java-bindings/JImageProxyHostObject.h
View File

@@ -18,8 +18,7 @@ using namespace facebook;
class JSI_EXPORT JImageProxyHostObject : public jsi::HostObject {
public:
explicit JImageProxyHostObject(jni::local_ref<JImageProxy::javaobject> image): frame(image) {}
~JImageProxyHostObject();
explicit JImageProxyHostObject(jni::alias_ref<JImageProxy::javaobject> image): frame(image) {}
public:
jsi::Value get(jsi::Runtime &, const jsi::PropNameID &name) override;
@@ -28,7 +27,7 @@ class JSI_EXPORT JImageProxyHostObject : public jsi::HostObject {
void close();
public:
jni::local_ref<JImageProxy> frame;
jni::alias_ref<JImageProxy> frame;
private:
static auto constexpr TAG = "VisionCamera";