railbird/react-native-vision-camera
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Fix CamcorderProfile get crash on Samsung devices (#1907)

Browse Source
This commit is contained in:
Marc Rousavy 2023-10-03 12:04:03 +02:00 committed by GitHub
parent 1cdc3d1d9c
commit 83c0cdb030
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
package/android/src/main/java/com/mrousavy/camera/extensions/CameraCharacteristics+getOutputSizes.kt
View File

@ -6,23 +6,28 @@ import android.os.Build
import android.util.Size import android.util.Size
private fun getMaximumVideoSize(cameraId: String): Size? { private fun getMaximumVideoSize(cameraId: String): Size? {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) { try {
val profiles = CamcorderProfile.getAll(cameraId, CamcorderProfile.QUALITY_HIGH) if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
if (profiles != null) { val profiles = CamcorderProfile.getAll(cameraId, CamcorderProfile.QUALITY_HIGH)
val largestProfile = profiles.videoProfiles.filterNotNull().maxByOrNull { it.width * it.height } if (profiles != null) {
if (largestProfile != null) { val largestProfile = profiles.videoProfiles.filterNotNull().maxByOrNull { it.width * it.height }
return Size(largestProfile.width, largestProfile.height) if (largestProfile != null) {
return Size(largestProfile.width, largestProfile.height)
}
} }
} }
}
val cameraIdInt = cameraId.toIntOrNull() val cameraIdInt = cameraId.toIntOrNull()
if (cameraIdInt != null) { if (cameraIdInt != null) {
val profile = CamcorderProfile.get(cameraIdInt, CamcorderProfile.QUALITY_HIGH) val profile = CamcorderProfile.get(cameraIdInt, CamcorderProfile.QUALITY_HIGH)
return Size(profile.videoFrameWidth, profile.videoFrameHeight) return Size(profile.videoFrameWidth, profile.videoFrameHeight)
} }
return null return null
} catch (e: Throwable) {
// some Samsung phones just crash when trying to get the CamcorderProfile. Only god knows why.
return null
}
} }
fun CameraCharacteristics.getVideoSizes(cameraId: String, format: Int): List<Size> { fun CameraCharacteristics.getVideoSizes(cameraId: String, format: Int): List<Size> {