railbird/react-native-vision-camera
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Fix CamcorderProfile get crash on Samsung devices (#1907)

Browse Source
This commit is contained in:
Marc Rousavy 2023-10-03 12:04:03 +02:00 committed by GitHub
parent 1cdc3d1d9c
commit 83c0cdb030
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
package/android/src/main/java/com/mrousavy/camera/extensions/CameraCharacteristics+getOutputSizes.kt
View File

@ -6,6 +6,7 @@ import android.os.Build
import android.util.Size import android.util.Size
private fun getMaximumVideoSize(cameraId: String): Size? { private fun getMaximumVideoSize(cameraId: String): Size? {
try {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) { if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
val profiles = CamcorderProfile.getAll(cameraId, CamcorderProfile.QUALITY_HIGH) val profiles = CamcorderProfile.getAll(cameraId, CamcorderProfile.QUALITY_HIGH)
if (profiles != null) { if (profiles != null) {
@ -23,6 +24,10 @@ private fun getMaximumVideoSize(cameraId: String): Size? {
} }
return null return null
} catch (e: Throwable) {
// some Samsung phones just crash when trying to get the CamcorderProfile. Only god knows why.
return null
}
} }
fun CameraCharacteristics.getVideoSizes(cameraId: String, format: Int): List<Size> { fun CameraCharacteristics.getVideoSizes(cameraId: String, format: Int): List<Size> {