railbird/react-native-vision-camera
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Fix maxImages have been acquired error in Frame Processor (#2430)

Browse Source 
* fix: maxImages when frameprocessor error

* fix: Use `try`/`finally` for safety

---------

Co-authored-by: Marc Rousavy <me@mrousavy.com>
This commit is contained in:
Daniel Prado 2024-01-25 14:17:48 -03:00 committed by GitHub
parent 4041ee8cbd
commit 7e2889cf84
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
package/android/src/main/java/com/mrousavy/camera/core/VideoPipeline.kt
View File

@ -110,20 +110,22 @@ class VideoPipeline(
Log.i(TAG, "ImageReader::onImageAvailable!") Log.i(TAG, "ImageReader::onImageAvailable!")
val image = reader.acquireNextImage() ?: return@setOnImageAvailableListener val image = reader.acquireNextImage() ?: return@setOnImageAvailableListener
try {
// TODO: Get correct orientation and isMirrored // TODO: Get correct orientation and isMirrored
val frame = Frame(image, image.timestamp, Orientation.PORTRAIT, isMirrored) val frame = Frame(image, image.timestamp, Orientation.PORTRAIT, isMirrored)
frame.incrementRefCount() frame.incrementRefCount()
try {
frameProcessor?.call(frame) frameProcessor?.call(frame)
if (hasOutputs) { if (hasOutputs) {
// If we have outputs (e.g. a RecordingSession), pass the frame along to the OpenGL pipeline // If we have outputs (e.g. a RecordingSession), pass the frame along to the OpenGL pipeline
imageWriter!!.queueInputImage(image) imageWriter!!.queueInputImage(image)
} }
frame.decrementRefCount()
} catch (e: Throwable) { } catch (e: Throwable) {
Log.e(TAG, "Failed to call Frame Processor!", e) Log.e(TAG, "FrameProcessor/ImageReader pipeline threw an error!", e)
throw e
} finally {
frame.decrementRefCount()
} }
}, CameraQueues.videoQueue.handler) }, CameraQueues.videoQueue.handler)