feat: Use correct photo and video format dimensions on iOS (#1929)

* feat: Use new photo dimensions API

* Update AVCaptureDevice.Format+matchesFilter.swift

* fix: Use Pixels instead of Points for video size

* feat: Set `PhotoOutput`'s maximum photo resolution

* fix: Compare dictionaries instead

* chore: Format code

* fix: Try to use hash.... failing atm

* fix: Use rough comparison again

* fix: Also take video HDR into consideration

* chore: Format

* Use contains

* Update AVCaptureDevice.Format+toDictionary.swift

* docs: Add better docs to Camera props

* Update CameraView+AVCaptureSession.swift

* Update CameraView+AVCaptureSession.swift

package/ios/Extensions/AVCaptureDevice.Format+toDictionary.swift

@@ -35,22 +35,32 @@ extension AVCaptureDevice.Format {
     return maxRange?.maxFrameRate ?? 0
   }
 
-  func toDictionary() -> [String: Any] {
+  var supportsVideoHDR: Bool {
+    let pixelFormat = CMFormatDescriptionGetMediaSubType(formatDescription)
+    let hdrFormats = [
+      kCVPixelFormatType_420YpCbCr10BiPlanarFullRange,
+      kCVPixelFormatType_420YpCbCr10BiPlanarVideoRange,
+      kCVPixelFormatType_Lossless_420YpCbCr10PackedBiPlanarVideoRange,
+    ]
+    return hdrFormats.contains(pixelFormat)
+  }
+
+  func toDictionary() -> [String: AnyHashable] {
     let availablePixelFormats = AVCaptureVideoDataOutput().availableVideoPixelFormatTypes
     let pixelFormats = availablePixelFormats.map { format in PixelFormat(mediaSubType: format) }
 
     return [
       "videoStabilizationModes": videoStabilizationModes.map(\.descriptor),
       "autoFocusSystem": autoFocusSystem.descriptor,
-      "photoHeight": highResolutionStillImageDimensions.height,
-      "photoWidth": highResolutionStillImageDimensions.width,
+      "photoHeight": photoDimensions.height,
+      "photoWidth": photoDimensions.width,
       "videoHeight": videoDimensions.height,
       "videoWidth": videoDimensions.width,
       "maxISO": maxISO,
       "minISO": minISO,
       "fieldOfView": videoFieldOfView,
       "maxZoom": videoMaxZoomFactor,
-      "supportsVideoHDR": availablePixelFormats.contains(kCVPixelFormatType_420YpCbCr10BiPlanarFullRange),
+      "supportsVideoHDR": supportsVideoHDR,
       "supportsPhotoHDR": false,
       "minFps": minFrameRate,
       "maxFps": maxFrameRate,
@@ -58,4 +68,29 @@ extension AVCaptureDevice.Format {
       "supportsDepthCapture": !supportedDepthDataFormats.isEmpty,
     ]
   }
+
+  /**
+   Compares this format to the given JS `CameraDeviceFormat`.
+   Only the most important properties (such as dimensions and FPS) are taken into consideration,
+   so this is not an exact equals, but more like a "matches filter" comparison.
+   */
+  func isEqualTo(jsFormat dict: NSDictionary) -> Bool {
+    guard dict["photoWidth"] as? Int32 == photoDimensions.width && dict["photoHeight"] as? Int32 == photoDimensions.height else {
+      return false
+    }
+
+    guard dict["videoWidth"] as? Int32 == videoDimensions.width && dict["videoHeight"] as? Int32 == videoDimensions.height else {
+      return false
+    }
+
+    guard dict["minFps"] as? Float64 == minFrameRate && dict["maxFps"] as? Float64 == maxFrameRate else {
+      return false
+    }
+
+    guard dict["supportsVideoHDR"] as? Bool == supportsVideoHDR else {
+      return false
+    }
+
+    return true
+  }
 }