railbird/react-native-vision-camera
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Fix format Preview and Video Capture resolution setting (#325)

Browse Source 
* fix: Actually use a format's `videoSize` for Preview/Video Capture

* `setDefaultResolution` -> `setTargetResolution`
This commit is contained in:
Marc Rousavy 2021-08-05 15:54:01 +02:00 committed by GitHub
parent 1c32726ef6
commit 37db643f71
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
android/src/main/java/com/mrousavy/camera/CameraView.kt
View File

@ -356,10 +356,9 @@ class CameraView(context: Context) : FrameLayout(context), LifecycleOwner {
// User has selected a custom format={}. Use that // User has selected a custom format={}. Use that
val format = DeviceFormat(format!!) val format = DeviceFormat(format!!)
Log.i(TAG, "Using custom format - photo: ${format.photoSize}, video: ${format.videoSize} @ $fps FPS") Log.i(TAG, "Using custom format - photo: ${format.photoSize}, video: ${format.videoSize} @ $fps FPS")
val aspectRatio = aspectRatio(format.photoSize.width, format.photoSize.height) previewBuilder.setTargetResolution(format.videoSize)
previewBuilder.setTargetAspectRatio(aspectRatio) imageCaptureBuilder.setTargetResolution(format.photoSize)
imageCaptureBuilder.setDefaultResolution(format.photoSize) videoCaptureBuilder.setTargetResolution(format.videoSize)
videoCaptureBuilder.setDefaultResolution(format.photoSize)
fps?.let { fps -> fps?.let { fps ->
if (format.frameRateRanges.any { it.contains(fps) }) { if (format.frameRateRanges.any { it.contains(fps) }) {