railbird/react-native-vision-camera
9
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf: Remove a few unnecessary log statements

Browse Source
This commit is contained in:
Marc Rousavy 2021-06-28 18:30:42 +02:00
parent 0f0f1fbb07
commit 26d19d5152
4 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
android/src/main/cpp/CameraView.cpp
View File

@ -37,7 +37,6 @@ void CameraView::frameProcessorCallback(const alias_ref<JImageProxy::javaobject>
auto frameStrong = make_local(frame); auto frameStrong = make_local(frame);
try { try {
__android_log_write(ANDROID_LOG_INFO, TAG, "Calling Frame Processor...");
frameProcessor_(frameStrong); frameProcessor_(frameStrong);
} catch (const std::exception& exception) { } catch (const std::exception& exception) {
// TODO: jsi::JSErrors cannot be caught on Hermes. They crash the entire app. // TODO: jsi::JSErrors cannot be caught on Hermes. They crash the entire app.

2
android/src/main/cpp/FrameProcessorRuntimeManager.cpp
View File

@ -133,8 +133,6 @@ void FrameProcessorRuntimeManager::installJSIBindings() {
// assign lambda to frame processor // assign lambda to frame processor
cameraView->setFrameProcessor([&rt, function](jni::local_ref<JImageProxy::javaobject> frame) { cameraView->setFrameProcessor([&rt, function](jni::local_ref<JImageProxy::javaobject> frame) {
__android_log_write(ANDROID_LOG_INFO, TAG, "Frame Processor called!");
// create HostObject which holds the Frame (JImageProxy) // create HostObject which holds the Frame (JImageProxy)
auto hostObject = std::make_shared<JImageProxyHostObject>(frame); auto hostObject = std::make_shared<JImageProxyHostObject>(frame);
function->call(rt, jsi::Object::createFromHostObject(rt, hostObject)); function->call(rt, jsi::Object::createFromHostObject(rt, hostObject));

1
android/src/main/cpp/JImageProxyHostObject.cpp
View File

@ -23,7 +23,6 @@ std::vector<jsi::PropNameID> JImageProxyHostObject::getPropertyNames(jsi::Runtim
jsi::Value JImageProxyHostObject::get(jsi::Runtime& runtime, const jsi::PropNameID& propNameId) { jsi::Value JImageProxyHostObject::get(jsi::Runtime& runtime, const jsi::PropNameID& propNameId) {
auto name = propNameId.utf8(runtime); auto name = propNameId.utf8(runtime);
__android_log_write(ANDROID_LOG_INFO, TAG, ("Getting prop \"" + name + "\"...").c_str());
if (name == "toString") { if (name == "toString") {
auto toString = [this] (jsi::Runtime& runtime, const jsi::Value& thisValue, const jsi::Value* arguments, size_t count) -> jsi::Value { auto toString = [this] (jsi::Runtime& runtime, const jsi::Value& thisValue, const jsi::Value* arguments, size_t count) -> jsi::Value {

1
android/src/main/java/com/mrousavy/camera/CameraView.kt
View File

@ -407,7 +407,6 @@ class CameraView(context: Context) : FrameLayout(context), LifecycleOwner {
val now = System.currentTimeMillis() val now = System.currentTimeMillis()
if (now - lastCall > intervalMs) { if (now - lastCall > intervalMs) {
lastCall = now lastCall = now
Log.d(TAG, "Calling Frame Processor...")
frameProcessorCallback(image) frameProcessorCallback(image)
} }
image.close() image.close()