Commit Graph

86 Commits

Author SHA1 Message Date
Don Nguyen
edf3a8c579 Remove observer of player before calling playerWithPlayerItem
It makes no sense if we move observer after calling calling playerWithPlayerItem because this is where the exception raises
2016-05-27 15:57:34 +07:00
Stanisław Chmiela
b6dc7c469b Remove observer providing context 2016-05-19 20:27:23 +02:00
Stanisław Chmiela
e7337227fe Remove observer only if it has been registered
Happens if someone creates Video component, but doesn't set src to it.
2016-05-17 09:40:58 +02:00
Stanisław Chmiela
88e47159d7 Remove observer in setSrc if the source changes, but the view hasn't been removed from superview
Before: observer removes only in removeFromSuperview, but adds in setSrc – multiple setSrc would add multiple observers and one removeFromSuperview would remove only one observer. Now: Every addObserver in setSrc is balanced by removeObserver also in setSrc
2016-05-17 09:40:26 +02:00
Stanisław Chmiela
901f0cc9ab Save current state of observing in _playbackRateObserverRegistered property 2016-05-17 09:38:35 +02:00
Stanisław Chmiela
5506805aac Add playbackRateObserverRegistered bool property 2016-05-17 09:37:11 +02:00
Stanisław Chmiela
654ae1a27c Merge pull request #199 from sjchmiela/feature/additional_playback_callbacks
Additional playback callbacks
2016-05-09 16:12:29 +02:00
Burak Çalık
0c3cce542f coding style fixes 2016-05-01 18:26:56 +03:00
Burak Çalık
91abfbde8b [iOS] Added orientation to onLoad event. 2016-05-01 17:41:30 +03:00
Stanisław Chmiela
e35eaf645f Don't require more details than we set to receive 2016-04-28 14:59:49 +02:00
Stanisław Chmiela
d1eae07cfa Unstall video in model 2016-04-28 14:56:50 +02:00
Stanisław Chmiela
b03c02b4f2 Fix Obj-C problem 2016-04-28 14:45:14 +02:00
Stanisław Chmiela
b37243fca2 Add playbackStalled and Resume events 2016-04-28 14:38:21 +02:00
Stanisław Chmiela
b55f71a29d Add onPlaybackRateChange callback 2016-04-28 14:37:45 +02:00
Stanisław Chmiela
f244f662b6 Add observer for _player rate 2016-04-28 14:29:09 +02:00
Stanisław Chmiela
505b94f9a6 Add sending onReadyForDisplay callback 2016-04-28 14:28:29 +02:00
Stanisław Chmiela
eb3fc2373a Add readyForDisplay callback 2016-04-28 14:25:45 +02:00
Brent Vatne
3c6da9782f Merge pull request #181 from sjchmiela/feature/support_fullscreen_mode
Support fullscreen mode
2016-04-12 14:13:50 -04:00
Stanisław Chmiela
e7cae171fb Add naturalSize to callback 2016-04-08 11:10:22 +02:00
Stanisław Chmiela
d304bfecbe Fix possibility of trying to open multiple fullscreen video players 2016-04-01 14:56:03 +02:00
Stanisław Chmiela
4120a2a3b2 Rename variable fullScreen to fullscreen 2016-04-01 14:55:23 +02:00
Stanisław Chmiela
9635a0d76b Do not trigger unsatisfiable constraints alert when possible 2016-04-01 13:04:16 +02:00
Stanisław Chmiela
3b3761dc81 Apply modifiers after fullscreen player dismissal 2016-04-01 12:52:23 +02:00
Stanisław Chmiela
b030a5587b Fix controller not rotating 2016-04-01 12:34:52 +02:00
Stanisław Chmiela
931ea75edd Implement delegate in RCTVideo 2016-04-01 10:52:05 +02:00
Stanisław Chmiela
d073847ce0 Fix dismissal code not running by creating subclass of view controller and notifying view 2016-03-31 23:10:25 +02:00
Stanisław Chmiela
6d05b7bf79 Add option for listening to fullscreen player events 2016-03-31 21:35:10 +02:00
Stanisław Chmiela
6ab72c4cb8 Move View Controller retrieval to external UIView category 2016-03-31 20:51:22 +02:00
Stanisław Chmiela
5244a5b797 Add _fullscreen property to the view 2016-03-31 20:34:22 +02:00
Stanisław Chmiela
9be76e3674 Add view controller finding functions
We need them to be able to present another view controller
2016-03-31 20:34:08 +02:00
Joel Arvidsson
5a96daac51 Fixes bug making it impossible to pause video from controls. 2016-02-18 21:45:09 -03:00
Bernd Paradies
f2b0dbd2db Introducing custom/native/embed skins 2015-12-22 17:39:04 -06:00
React Native Playground
b43d11f17b remove unused constants 2015-08-23 02:30:18 +02:00
Joshua Sierles
5718d17f90 switch to returning an array from customDirectEventTypes, for RN 0.10.0 compatibility 2015-08-22 21:42:26 +02:00
Baris Sencan
28d482852d Act according to playbackLikelyToKeepUp changes
Closes #57
This commit also includes some code style updates
2015-08-05 15:53:42 +03:00
Baris Sencan
0429094d74 Merge dpeek/fix/paused-resumes-after-seek into master
Fixes #73 as well
2015-07-20 19:46:49 +03:00
Brent Vatne
cb3c519195 Merge pull request #78 from dpeek/fix/disable-layer-resize-animation
Disables default system animation when resizing AVPlayerLayer
2015-07-18 20:32:59 -07:00
Baris Sencan
8a4fbaf6f7 Remove dispatch_async calls to main queue
Due to the changes made in #77
2015-07-18 15:38:56 +03:00
David Peek
0513930399 Disables default system animation when resizing AVPlayerLayer
Not sure if this something you will want – perhaps it could go behind a flag. When animating video size, the default system animation makes the rendered size of the video lag behind the bounds of the react view. This patch disables the default animation, ensuring the video renders at the correct size.
2015-07-14 16:35:29 +01:00
David Peek
153eb59c41 Call setRate instead of pause/play as they are equivalent (fixes #75)
Video was resuming after seek when setRate was called after play/pause in applyModifiers. According
to Apple's docs play/pause are equivalent to setRate:1.0 and setRate:0.0, meaning that if rate was
1.0 the video resumed after seeking completed.
2015-07-14 11:06:50 +01:00
Baris Sencan
dae2ea2f66 Merge pull request #70 from brentvatne/fix/player-access
Fix issues that arise due to accessing _player on a queue other than main
2015-07-01 14:16:59 -07:00
Baris Sencan
e8e3ffec89 Set volume and muted properties on main queue 2015-06-28 23:23:31 -07:00
Bernd Paradies
d4b62e252d Mild clean ups 2015-06-27 16:03:24 -07:00
Baris Sencan
3b53194839 Rename playerItemDidEnd as playerItemDidReachEnd 2015-06-26 15:13:03 -07:00
Baris Sencan
c985957dd5 Set player rate on main thread 2015-06-26 15:12:33 -07:00
Baris Sencan
bcecb6ed81 Set video gravity on main thread 2015-06-26 15:12:09 -07:00
Baris Sencan
f83da614cf Seek to time on main thread 2015-06-26 15:09:10 -07:00
Baris Sencan
449b97a6c2 Fix setPaused threading
Fixes #66
2015-06-26 14:31:03 -07:00
Josh Habdas
54ea11badd Remove Notification Center observers on dealloc 2015-06-26 13:41:41 -05:00
Brent Vatne
1f901be363 Pause video when the app is backgrounded 2015-06-25 15:40:46 -07:00