Commit Graph

230 Commits

Author SHA1 Message Date
Nahuel Marisi
7a9081d5af Removing the call to observeValueForKeyPath:ofObject:change:context: on super from RCTVideo.
If the super class is not actually observing the key, the app will crash. Checking to see if
the super class responds to this selector doesn't solve this issue.

react-native-video github issue: https://github.com/react-native-community/react-native-video/issues/1515

Discussion about this particular problem: https://stackoverflow.com/questions/6574714/whats-wrong-with-this-observevalueforkeypathofobjectchangecontext-implement
2019-08-20 09:37:49 +02:00
Daniel Mariño Ruiz
eae487c57e
Merge branch 'release/4.4.3' into feature/fix-when-muted-and-controls 2019-07-08 12:15:55 +02:00
Daniel Mariño
576273d712 fix when controls & muted 2019-07-06 13:58:18 +02:00
Daniel Mariño Ruiz
9bc709f35e
Merge branch 'release/4.4.3' into master 2019-07-04 10:05:54 +02:00
Jens Andersson
3d2a58a8c5 Fix memory leak when using AVPlayerViewController, make sure to release player 2019-07-03 08:44:55 +02:00
Zaid Daghestani
4a3ea93739 bring back super KVO with selector check 2019-07-02 13:36:13 -07:00
Zaid Daghestani
6de06f1f54
Remove calls to [super observe] to fix crash 2019-07-01 14:56:41 -07:00
Jens Andersson
cb3e8c8281
Merge branch 'release/4.4.2' into posterfix 2019-06-20 09:06:13 +01:00
Daniel Mariño Ruiz
92f7459e6d
Merge pull request #1614 from jenshandersson/master
Remove video player when entering background correctly
2019-06-19 21:11:42 +02:00
Jens Andersson
420332e078 Implemented onReadyForDisplay for iOS when using controls 2019-06-19 14:18:25 +01:00
Daniel Mariño
32796e9a54 Change also RCTVideo.h 2019-06-19 09:22:10 +02:00
CHaNGeTe
112608cbaf RCTDirectEventBlock 2019-06-18 07:31:17 +02:00
Jens Andersson
a0bb083064 Remove video layer when entering background correctly, both if using controls or not 2019-06-17 09:09:04 +01:00
Hampton Maxwell
c36a9cf2ef
Merge pull request #1441 from nfb-onf/1319-fullscreen-rotation-issues
1319 - fullscreen rotation issues with iOS built-in controls
2019-03-12 21:52:10 -07:00
Kyle Bedell
5dbf7e2b54 Remove unused delegate in header file. 2019-03-12 11:21:12 -07:00
Kyle Bedell
933bbae77b Fix tvOS picture-in-picture compilation regression. 2019-03-11 19:55:36 -07:00
Hampton Maxwell
d5fe47f238
Merge pull request #1325 from Khan/pip
Implement picture in picture for iOS
2019-02-18 22:13:02 -08:00
Hampton Maxwell
f69231fe81
Merge pull request #1246 from niklassaers/master
Instead of crashing, show a warning and return
2019-02-18 21:34:46 -08:00
Hampton Maxwell
075dfbaf7f
Only check for an empty source 2019-02-18 21:34:34 -08:00
Laurin Quast
d8a2a9e108
fix(ios): message sent to deallocated instance (#1482)
* fix(ios): message sent to deallocated instance

* chore: update changelog
2019-02-14 16:34:14 +01:00
Ash Mishra
b6ed6819f0 Fix missing layout calls in full-screen when using built-in video controls on iOS 2019-01-24 16:04:31 -08:00
Laurin Quast
125d5dc9c5
fix: omit packager assets from caching (#1438) 2019-01-24 13:15:58 +01:00
Abdulrahman Alzenki
62dc913cb3 Address some of the feedback from the pull reqeust 2019-01-07 10:41:30 -08:00
Abdulrahman Alzenki
617b046789 Implement picture in picture for iOS
Test Plan:
 - Run on ipad
 - test out onIsPictureInPictureSupported, onIsPictureInPictureActive, restoreUserInterfaceForPictureInPictureStop, startPictureInPicture, stopPictureInPicture
2019-01-07 10:26:20 -08:00
Hampton Maxwell
fb5f87bc9b Disable onBandwidthUpdate for iOS since it's not working yet 2018-12-31 22:06:50 -08:00
Hampton Maxwell
72f896d6df
Don't format bandwidth update bitrate 2018-12-31 21:39:12 -08:00
Hampton Maxwell
45a851e79a
Merge branch 'master' into master 2018-12-31 21:36:49 -08:00
Hampton Maxwell
b7a351c043
Merge pull request #1384 from nickgzzjr/master
Added filterEnabled flag and don't enable filter if source is an hls playlist
2018-12-30 19:19:33 -08:00
Hampton Maxwell
75b07d7442 Applying modifers while loading a new source causes loading a new video not to display 2018-12-22 15:33:43 -08:00
Hampton Maxwell
f401c6a287
Small code cleanup to setFilter 2018-12-20 10:45:14 -08:00
Nicolas Gonzalez
c2d9fb4301 merge 2018-12-13 21:38:32 -06:00
Nicolas Gonzalez
ebb237dc60 RCTVideo.m formatting 2018-12-13 21:37:17 -06:00
Nicolas Gonzalez
67a963328a updated basic example, added filterEnabled flag, check for HLS playlist before applying filter 2018-12-13 21:30:38 -06:00
Hampton Maxwell
a43f9c7ce1
Merge branch 'master' into maximumBitRate-adaptive-streaming 2018-12-12 22:30:52 -08:00
Hampton Maxwell
e5bada9fc6
Merge pull request #1360 from nickgzzjr/master
Only apply filter if filter is set
2018-12-12 22:23:06 -08:00
Hampton Maxwell
a4a0c8ad17
Refactor setFilter code 2018-12-12 22:21:19 -08:00
Hampton Maxwell
8119cede8e
Merge pull request #1304 from nfb-onf/disable_airplay_for_sideloaded_captions
disable airplay when sideloaded captions
2018-12-05 17:37:22 -08:00
Nicolas Gonzalez
97ac68745b only apply filter if filter is set 2018-12-01 21:58:12 -06:00
Hampton Maxwell
977877f529 Remove unused onVideoSaved event 2018-11-27 18:51:03 -08:00
Ash Mishra
5ab8165c3d renamed maximumBitRate to maxBitRate. Added applyModifiers support 2018-11-26 14:50:31 -08:00
Ash Mishra
11db343987 Support for HLS maximum bit rate adaptive streaming 2018-11-26 10:33:09 -08:00
Nicolas Gonzalez
0152db8f5a Fixed Conflict in CHANGELOG.md 2018-11-18 14:12:01 -06:00
Nicolas Gonzalez
8fc77acc9c only set filter after creating playerItem 2018-11-18 11:15:03 -06:00
Nicolas Gonzalez
8a3b6490dc Updated save function README, updated video-caching example to test saving function 2018-11-06 20:33:33 -06:00
Nicolas Gonzalez
22d65addd3 Added FilterType.js with all filters that do not require extra parameters 2018-11-06 08:38:28 -06:00
Nicolas Gonzalez
67f01aae90 undo code formatting 2nd try 2018-10-27 20:50:33 -05:00
Nicolas Gonzalez
fbeca99c27 undo code formatting 2018-10-27 20:43:14 -05:00
sridhar
aa526206d2 Merge branch 'master' of git://github.com/react-native-community/react-native-video into react-native-community-master
Merge branch 'master' of git://github.com/react-native-community/react-native-video into react-native-community-master
2018-10-27 09:19:28 +05:30
Nicolas Gonzalez
16e45fc9f1 added ability to export video 2018-10-26 08:21:41 -05:00
Ash Mishra
67406b5e7b restored autorotate to fullscreen options 2018-10-25 14:56:59 -07:00
Nicolas Gonzalez
18e8895712 added video filter 2018-10-25 08:56:20 -05:00
Hampton Maxwell
2c391f5807
Merge pull request #1298 from relivecc/ios-cached-asset
return cached asset
2018-10-23 19:18:24 -07:00
Frikkie Snyman
f0a1bebc04 return cached asset 2018-10-23 16:09:19 +02:00
Ash Mishra
7026ca7e51 disable airplay when sideloaded captions 2018-10-18 15:21:46 -07:00
Ash Mishra
bbf37ed5cb Removed autoRotate from codebase; added TV_OS target check for
orientation; added tvOS target to examples/basic/ios project
2018-10-11 16:42:11 -07:00
Hampton Maxwell
0646dca071 Split fullscreen options into separate props 2018-10-07 20:24:50 -07:00
Hampton Maxwell
5336d4f866
Merge branch 'master' into master 2018-10-07 16:07:11 -07:00
Hampton Maxwell
777247907d Namespace onExternalPlaybackChange as onVideoExternalPlaybackChange 2018-10-07 15:59:10 -07:00
Niklas Saers
865db71179 Doh, should of course be AND, not OR 2018-09-20 13:38:39 +02:00
Niklas Saers
c37507768c Instead of crashing, show a warning and return 2018-09-19 12:02:55 +02:00
Artur Jaworski
d7efcf315f introducing onExternalPlaybackActiveChange 2018-09-13 15:49:49 +02:00
Ash Mishra
443bf88c63 Adds fullscreenOptions to iOS 2018-09-04 16:05:45 -07:00
Ash Mishra
0580f2710f Merge branch 'master' of https://github.com/nfb-onf/react-native-video
# Conflicts:
#	ios/RCTVideoPlayerViewController.m
#	ios/Video/RCTVideo.m
2018-09-04 15:26:56 -07:00
Ash Mishra
77c48c9dfc added an onCaptionsDeviceSettings event 2018-09-04 15:19:32 -07:00
Ash Mishra
37c31a3c92 Improvements to urlFilePath so that it only does a /Documents/ folder check if the file does not exist; improvements to full-screen options for iOS to default autorotate, and to respect landscape / portrait masks 2018-09-04 15:17:54 -07:00
Ash Mishra
3b0d459230 Fix for files that are stored in the Documents folder on iOS (and not as resources in the JS app) 2018-09-04 15:17:19 -07:00
Ash Mishra
f45d6a2c3e Added fullscreen options for iOS Player 2018-09-04 15:15:30 -07:00
Ash Mishra
3ba26eb45a Working on autorotation of video player 2018-09-04 15:08:56 -07:00
Hampton Maxwell
b6512e4316 Remove old test var 2018-08-27 18:19:15 -07:00
Hampton Maxwell
67a388911d Add debug message when disabling caching due to text tracks 2018-08-27 18:16:59 -07:00
Hampton Maxwell
b6ee8f7fed Simplify text track + cache bypass code 2018-08-27 18:05:41 -07:00
Hampton Maxwell
a26dc264b2
Bypass cache when sideloaded text tracks are specified
Fixes a crash when using the cache & sideloaded text tracks together due to the tracks on the asset not being available. Re-visit when someone with more expertise on the cache can look at it.
2018-08-27 17:55:33 -07:00
Hampton Maxwell
86d655c3d1 Refactor to move caching code into a single block 2018-08-08 15:37:18 -07:00
Laurin Quast
8fcdc6e02a Merge remote-tracking branch 'upstream/master' into implement-ios-caching 2018-08-06 10:39:39 +02:00
Laurin Quast
c9e2ba0547 Fix URLs with query strings at the end, e.g. ?size=large
Fix HLS Playlists (only support mp4, m4v and mov file extension)

Add debug logging for guiding library consumers about why their video is not cached
2018-08-05 23:06:25 +02:00
Laurin Quast
9f2cb8f92d Merge remote-tracking branch 'upstream/master' into implement-ios-caching 2018-08-01 00:11:35 +02:00
Laurin Quast
685133ea48 remove cache property 2018-07-31 23:47:55 +02:00
Laurin Quast
2260ae5b8c Merge remote-tracking branch 'upstream/master' into implement-ios-caching 2018-07-30 21:20:34 +02:00
Laurin Quast
82edb959d8 remove cache property 2018-07-19 09:08:55 +02:00
Laurin Quast
4f386d2c93 make video cache feature optional 2018-07-19 02:06:09 +02:00