railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #3247 from chrisglein/windowsOnError

Browse Source 
Fix lack of `onError` event for Windows
This commit is contained in:
Olivier Bouillet 2023-09-19 08:56:33 +02:00 committed by GitHub
commit ef5c63fdd2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
API.md
View File

@ -352,7 +352,7 @@ var styles = StyleSheet.create({
| [onBandwidthUpdate](#onbandwidthupdate) | Android | | [onBandwidthUpdate](#onbandwidthupdate) | Android |
| [onBuffer](#onbuffer) | Android, iOS | | [onBuffer](#onbuffer) | Android, iOS |
| [onEnd](#onend) | All | | [onEnd](#onend) | All |
| [onError](#onerror) | Android, iOS | | [onError](#onerror) | Android, iOS, Windows UWP |
| [onExternalPlaybackChange](#onexternalplaybackchange) | iOS | | [onExternalPlaybackChange](#onexternalplaybackchange) | iOS |
| [onFullscreenPlayerWillPresent](#onfullscreenplayerwillpresent) | Android, iOS | | [onFullscreenPlayerWillPresent](#onfullscreenplayerwillpresent) | Android, iOS |
| [onFullscreenPlayerDidPresent](#onfullscreenplayerdidpresent) | Android, iOS | | [onFullscreenPlayerDidPresent](#onfullscreenplayerdidpresent) | Android, iOS |

1
CHANGELOG.md
View File

@ -1,6 +1,7 @@
## Changelog ## Changelog
## Next ## Next
- Windows: fix `onError` not being raised [#3247](https://github.com/react-native-video/react-native-video/pull/3247)
### Version 6.0.0-alpha.8 ### Version 6.0.0-alpha.8
- All: Playing audio over earpiece [#2887](https://github.com/react-native-video/react-native-video/issues/2887) - All: Playing audio over earpiece [#2887](https://github.com/react-native-video/react-native-video/issues/2887)

8
windows/ReactNativeVideoCPP/ReactVideoView.cpp
View File

@ -132,7 +132,13 @@ void ReactVideoView::OnMediaOpened(IInspectable const &, IInspectable const &) {
}); });
} }
void ReactVideoView::OnMediaFailed(IInspectable const &, IInspectable const &) {} void ReactVideoView::OnMediaFailed(IInspectable const &, IInspectable const &) {
runOnQueue([weak_this{get_weak()}]() {
if (auto strong_this{weak_this.get()}) {
strong_this->m_reactContext.DispatchEvent(*strong_this, L"topError", nullptr);
}
});
}
void ReactVideoView::OnMediaEnded(IInspectable const &, IInspectable const &) { void ReactVideoView::OnMediaEnded(IInspectable const &, IInspectable const &) {
runOnQueue([weak_this{get_weak()}]() { runOnQueue([weak_this{get_weak()}]() {