diff --git a/CHANGELOG.md b/CHANGELOG.md index 40355cb7..7ae8411c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,9 @@ - Android: fix linter warning [#2891] (https://github.com/react-native-video/react-native-video/pull/2891) - Fix iOS RCTSwiftLog naming collision [#2868](https://github.com/react-native-video/react-native-video/issues/2868) - Added "homepage" to package.json [#2882](https://github.com/react-native-video/react-native-video/pull/2882) +- Fix regression when fullscreen prop is used combined with controls [#2911](https://github.com/react-native-video/react-native-video/pull/2911) - Fix: memory leak issue on iOS [#2907](https://github.com/react-native-video/react-native-video/pull/2907) +- Fix setting text tracks before player is initialized on iOS [#2935](https://github.com/react-native-video/react-native-video/pull/2935) - Feature: Add VAST support for AVOD [#2923](https://github.com/react-native-video/react-native-video/pull/2923) ### Version 6.0.0-alpha.3 diff --git a/android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java b/android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java index 01b632fa..27a79782 100644 --- a/android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java +++ b/android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java @@ -387,6 +387,15 @@ class ReactExoplayerView extends FrameLayout implements playerControlView = new PlayerControlView(getContext()); } + if (fullScreenPlayerView == null) { + fullScreenPlayerView = new FullScreenPlayerView(getContext(), exoPlayerView, playerControlView, new OnBackPressedCallback(true) { + @Override + public void handleOnBackPressed() { + setFullscreen(false); + } + }); + } + // Setting the player for the playerControlView playerControlView.setPlayer(player); playPauseControlContainer = playerControlView.findViewById(R.id.exo_play_pause_container); @@ -423,8 +432,9 @@ class ReactExoplayerView extends FrameLayout implements }); //Handling the fullScreenButton click event - ImageButton fullScreenButton = playerControlView.findViewById(R.id.exo_fullscreen); + final ImageButton fullScreenButton = playerControlView.findViewById(R.id.exo_fullscreen); fullScreenButton.setOnClickListener(v -> setFullscreen(!isFullscreen)); + updateFullScreenButtonVisbility(); // Invoking onPlaybackStateChanged and onPlayWhenReadyChanged events for Player eventListener = new Player.Listener() { @@ -438,7 +448,6 @@ class ReactExoplayerView extends FrameLayout implements if (pauseButton != null && pauseButton.getVisibility() == GONE) { pauseButton.setVisibility(INVISIBLE); } - reLayout(playPauseControlContainer); //Remove this eventListener once its executed. since UI will work fine once after the reLayout is done player.removeListener(eventListener); @@ -458,7 +467,7 @@ class ReactExoplayerView extends FrameLayout implements * Adding Player control to the frame layout */ private void addPlayerControl() { - if(player == null) return; + if(playerControlView == null) return; LayoutParams layoutParams = new LayoutParams( LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT); @@ -716,12 +725,6 @@ class ReactExoplayerView extends FrameLayout implements setControls(controls); applyModifiers(); startBufferCheckTimer(); - fullScreenPlayerView = new FullScreenPlayerView(getContext(), exoPlayerView, playerControlView, new OnBackPressedCallback(true) { - @Override - public void handleOnBackPressed() { - setFullscreen(false); - } - }); } private DrmSessionManager buildDrmSessionManager(UUID uuid, String licenseUrl, String[] keyRequestPropertiesArray) throws UnsupportedDrmException { @@ -1825,6 +1828,22 @@ class ReactExoplayerView extends FrameLayout implements this.disableBuffering = disableBuffering; } + private void updateFullScreenButtonVisbility() { + if (playerControlView != null) { + final ImageButton fullScreenButton = playerControlView.findViewById(R.id.exo_fullscreen); + if (controls) { + //Handling the fullScreenButton click event + if (isFullscreen && fullScreenPlayerView != null && !fullScreenPlayerView.isShowing()) { + fullScreenButton.setVisibility(GONE); + } else { + fullScreenButton.setVisibility(VISIBLE); + } + } else { + fullScreenButton.setVisibility(GONE); + } + } + } + public void setDisableDisconnectError(boolean disableDisconnectError) { this.disableDisconnectError = disableDisconnectError; } @@ -1840,15 +1859,6 @@ class ReactExoplayerView extends FrameLayout implements return; } - if (fullScreenPlayerView == null) { - fullScreenPlayerView = new FullScreenPlayerView(getContext(), exoPlayerView, playerControlView, new OnBackPressedCallback(true) { - @Override - public void handleOnBackPressed() { - setFullscreen(false); - } - }); - } - Window window = activity.getWindow(); View decorView = window.getDecorView(); int uiOptions; @@ -1862,7 +1872,7 @@ class ReactExoplayerView extends FrameLayout implements | SYSTEM_UI_FLAG_FULLSCREEN; } eventEmitter.fullscreenWillPresent(); - if (controls) { + if (controls && fullScreenPlayerView != null) { fullScreenPlayerView.show(); } post(() -> { @@ -1872,7 +1882,7 @@ class ReactExoplayerView extends FrameLayout implements } else { uiOptions = View.SYSTEM_UI_FLAG_VISIBLE; eventEmitter.fullscreenWillDismiss(); - if (controls) { + if (controls && fullScreenPlayerView != null) { fullScreenPlayerView.dismiss(); reLayout(exoPlayerView); } @@ -1881,6 +1891,8 @@ class ReactExoplayerView extends FrameLayout implements eventEmitter.fullscreenDidDismiss(); }); } + // need to be done at the end to avoid hiding fullscreen control button when fullScreenPlayerView is shown + updateFullScreenButtonVisbility(); } public void setUseTextureView(boolean useTextureView) { @@ -1949,9 +1961,9 @@ class ReactExoplayerView extends FrameLayout implements */ public void setControls(boolean controls) { this.controls = controls; - if (player == null || exoPlayerView == null) return; if (controls) { addPlayerControl(); + updateFullScreenButtonVisbility(); } else { int indexOfPC = indexOfChild(playerControlView); if (indexOfPC != -1) { diff --git a/examples/basic/src/VideoPlayer.android.tsx b/examples/basic/src/VideoPlayer.android.tsx index 4b426ace..ef17ac5b 100644 --- a/examples/basic/src/VideoPlayer.android.tsx +++ b/examples/basic/src/VideoPlayer.android.tsx @@ -715,6 +715,7 @@ class VideoPlayer extends Component { paused={this.state.paused} volume={this.state.volume} muted={this.state.muted} + fullscreen={this.state.fullscreen} controls={this.state.showRNVControls} resizeMode={this.state.resizeMode} onLoad={this.onLoad} diff --git a/ios/Video/Features/RCTPlayerOperations.swift b/ios/Video/Features/RCTPlayerOperations.swift index cd0ddfec..8b76fafc 100644 --- a/ios/Video/Features/RCTPlayerOperations.swift +++ b/ios/Video/Features/RCTPlayerOperations.swift @@ -132,6 +132,8 @@ enum RCTPlayerOperations { let type = criteria?.type let group:AVMediaSelectionGroup! = player?.currentItem?.asset.mediaSelectionGroup(forMediaCharacteristic: characteristic) var mediaOption:AVMediaSelectionOption! + + guard group != nil else { return } if (type == "disabled") { // Do nothing. We want to ensure option is nil