railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ios): destroy adsManager when player detach from super view (#3716) (#3722)

Browse Source 
* fix(ios): destroy adsManager when player detach from super view (#3716)

* fix: swift format
This commit is contained in:
Nguyễn Bảo Khương 2024-05-01 16:31:20 +07:00 committed by GitHub
parent ecc946d1c1
commit e96c17321f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ios/Video/Features/RCTIMAAdsManager.swift
View File

@ -44,6 +44,16 @@
} }
} }
func releaseAds() {
guard let adsManager else { return }
// Destroy AdsManager may be delayed for a few milliseconds
// But what we want is it stopped producing sound immediately
// Issue found on tvOS 17, or iOS if view detach & STARTED event happen at the same moment
adsManager.volume = 0
adsManager.pause()
adsManager.destroy()
}
// MARK: - Getters // MARK: - Getters
func getAdsLoader() -> IMAAdsLoader? { func getAdsLoader() -> IMAAdsLoader? {

4
ios/Video/RCTVideo.swift
View File

@ -1187,6 +1187,10 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
_resouceLoaderDelegate = nil _resouceLoaderDelegate = nil
_playerObserver.clearPlayer() _playerObserver.clearPlayer()
#if USE_GOOGLE_IMA
_imaAdsManager.releaseAds()
#endif
self.removePlayerLayer() self.removePlayerLayer()
if let _playerViewController { if let _playerViewController {