From ce9a0cdfa2ce50be1d6aa629dddb23cb3c04da1c Mon Sep 17 00:00:00 2001
From: Seyed Mostafa Hasani <seyedmostafahassani@gmail.com>
Date: Mon, 27 May 2024 10:19:34 -0700
Subject: [PATCH] chore(android): add colors and dimens files to handle
 variables (#3836)

---
 .../layout/exo_legacy_player_control_view.xml | 32 +++++++++----------
 android/src/main/res/values/colors.xml        |  5 +++
 android/src/main/res/values/dimens.xml        | 16 ++++++++++
 3 files changed, 36 insertions(+), 17 deletions(-)
 create mode 100644 android/src/main/res/values/colors.xml
 create mode 100644 android/src/main/res/values/dimens.xml

diff --git a/android/src/main/res/layout/exo_legacy_player_control_view.xml b/android/src/main/res/layout/exo_legacy_player_control_view.xml
index bbe13a80..50ef45b2 100644
--- a/android/src/main/res/layout/exo_legacy_player_control_view.xml
+++ b/android/src/main/res/layout/exo_legacy_player_control_view.xml
@@ -4,14 +4,14 @@
     android:layout_height="wrap_content"
     android:layout_gravity="bottom"
     android:layoutDirection="ltr"
-    android:background="#CC000000"
+    android:background="@color/midnight_black"
     android:orientation="vertical">
 
     <LinearLayout
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
         android:gravity="center"
-        android:paddingTop="4dp"
+        android:paddingTop="@dimen/controller_wrapper_padding_top"
         android:orientation="horizontal">
 
         <ImageButton android:id="@+id/exo_prev"
@@ -42,42 +42,40 @@
     <LinearLayout
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:layout_marginTop="4dp"
+        android:layout_marginTop="@dimen/seekBar_wrapper_margin_top"
         android:gravity="center_vertical"
         android:orientation="horizontal">
 
         <TextView android:id="@+id/exo_position"
-            android:layout_width="50dp"
+            android:layout_width="@dimen/position_duration_width"
             android:layout_height="wrap_content"
-            android:textSize="14sp"
+            android:textSize="@dimen/position_duration_text_size"
             android:textStyle="bold"
-            android:paddingLeft="4dp"
-            android:paddingRight="4dp"
+            android:paddingHorizontal="@dimen/position_duration_horizontal_padding"
             android:includeFontPadding="false"
-            android:textColor="#FFBEBEBE"/>
+            android:textColor="@color/silver_gray"/>
 
         <androidx.media3.ui.DefaultTimeBar
             android:id="@+id/exo_progress"
             android:layout_width="0dp"
             android:layout_weight="1"
-            android:layout_height="26dp"/>
+            android:layout_height="@dimen/seekBar_height"/>
 
         <TextView android:id="@+id/exo_duration"
-            android:layout_width="50dp"
+            android:layout_width="@dimen/position_duration_width"
             android:layout_height="wrap_content"
-            android:textSize="14sp"
+            android:textSize="@dimen/position_duration_text_size"
             android:textStyle="bold"
-            android:paddingLeft="4dp"
-            android:paddingRight="4dp"
+            android:paddingHorizontal="@dimen/position_duration_horizontal_padding"
             android:includeFontPadding="false"
-            android:textColor="#FFBEBEBE"/>
+            android:textColor="@color/silver_gray"/>
 
         <ImageButton
             android:id="@+id/exo_fullscreen"
             style="@style/ExoMediaButton.FullScreen"
-            android:layout_width="30dp"
-            android:layout_height="30dp"
-            android:layout_margin="4dp"
+            android:layout_width="@dimen/full_screen_size"
+            android:layout_height="@dimen/full_screen_size"
+            android:layout_margin="@dimen/full_screen_margin"
             android:scaleType="fitCenter" />
     </LinearLayout>
 
diff --git a/android/src/main/res/values/colors.xml b/android/src/main/res/values/colors.xml
new file mode 100644
index 00000000..305f07c1
--- /dev/null
+++ b/android/src/main/res/values/colors.xml
@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <color name="silver_gray">#FFBEBEBE</color>
+    <color name="midnight_black">#CC000000</color>
+</resources>
\ No newline at end of file
diff --git a/android/src/main/res/values/dimens.xml b/android/src/main/res/values/dimens.xml
new file mode 100644
index 00000000..218dca64
--- /dev/null
+++ b/android/src/main/res/values/dimens.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+<!--    margin & padding-->
+    <dimen name="controller_wrapper_padding_top">4dp</dimen>
+    <dimen name="seekBar_wrapper_margin_top">4dp</dimen>
+    <dimen name="position_duration_horizontal_padding">4dp</dimen>
+    <dimen name="full_screen_margin">4dp</dimen>
+
+<!--    width & height-->
+    <dimen name="position_duration_width">50dp</dimen>
+    <dimen name="seekBar_height">26dp</dimen>
+    <dimen name="full_screen_size">30dp</dimen>
+
+<!--    textSize-->
+    <dimen name="position_duration_text_size">14sp</dimen>
+</resources>
\ No newline at end of file