railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

VEX-6625: Handle state to keep playing after gaining connection (#28)

Browse Source 
This PR handles autoplay after disconnection

Jira: VEX-6625

There was an error in react-native-video not being properly handled, in addition, the state of the player when reconnecting using a free user was not the expected one, requesting the player to keep playing when ready, made the behavior consistent in all scenarios

Velocity PR: crunchyroll/velocity#2430

Reviews
Major reviewer (domain expert): @jctorresM
Minor reviewer: @jacob-livingston
This commit is contained in:
Gabriel Rivero 2022-05-03 16:43:53 -04:00 committed by GitHub
parent b274541431
commit 9035e7dfc9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
android-exoplayer/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
View File

@ -817,7 +817,6 @@ class ReactExoplayerView extends FrameLayout implements
case Player.STATE_IDLE: case Player.STATE_IDLE:
case Player.STATE_ENDED: case Player.STATE_ENDED:
initializePlayer(); initializePlayer();
break;
case Player.STATE_BUFFERING: case Player.STATE_BUFFERING:
case Player.STATE_READY: case Player.STATE_READY:
if (!player.getPlayWhenReady()) { if (!player.getPlayWhenReady()) {
@ -827,7 +826,6 @@ class ReactExoplayerView extends FrameLayout implements
default: default:
break; break;
} }
} else { } else {
initializePlayer(); initializePlayer();
} }
@ -1314,6 +1312,12 @@ class ReactExoplayerView extends FrameLayout implements
setPlayWhenReady(true); setPlayWhenReady(true);
return; return;
} }
} else if (cause instanceof HttpDataSource.HttpDataSourceException) {
// this exception happens when connectivity is lost
updateResumePosition();
initializePlayer();
setPlayWhenReady(true);
return;
} else { } else {
errorCode = "2021"; errorCode = "2021";
errorString = getResources().getString(R.string.unrecognized_media_format); errorString = getResources().getString(R.string.unrecognized_media_format);