railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixes bug when pausing in fullscreen (iOS) (#325)

Browse Source 
Similar to #153, attempts to pause in fullscreen mode will be negated by the `playbackLikelyToKeepUp` event.

This PR adds a check for `_fullscreenPlayerPresented`, in additional to `_controls` before calling `setPaused` for `playbackLikelytoKeepUp`.

This update is likely preferrable to #258, as it doesn't lose the empty buffer check.
This commit is contained in:
Michael Crumm 2016-09-19 17:49:12 -07:00 committed by Matt Apperson
parent 7075e30ab8
commit 8c9168b582
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
RCTVideo.m
View File

@ -363,7 +363,7 @@ static NSString *const playbackRate = @"rate";
_playerBufferEmpty = YES;
} else if ([keyPath isEqualToString:playbackLikelyToKeepUpKeyPath]) {
// Continue playing (or not if paused) after being paused due to hitting an unbuffered zone.
if ((!_controls || _playerBufferEmpty) && _playerItem.playbackLikelyToKeepUp) {
if ((!(_controls || _fullscreenPlayerPresented) || _playerBufferEmpty) && _playerItem.playbackLikelyToKeepUp) {
[self setPaused:_paused];
}
_playerBufferEmpty = NO;