railbird/react-native-video
10
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

feat: refactor resize prop handler (#3286)

Browse Source
This commit is contained in:
Krzysztof Moch
2023-10-11 21:56:54 +02:00
committed by GitHub
parent 03a579e10f
commit 7fd7b3ff32
6 changed files with 47 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
ios/Video/RCTVideo.swift
View File

@@ -56,7 +56,7 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
private var _playWhenInactive:Bool = false
private var _ignoreSilentSwitch:String! = "inherit" // inherit, ignore, obey
private var _mixWithOthers:String! = "inherit" // inherit, mix, duck
private var _resizeMode:String! = "AVLayerVideoGravityResizeAspectFill"
private var _resizeMode:String! = "cover"
private var _fullscreen:Bool = false
private var _fullscreenAutorotate:Bool = true
private var _fullscreenOrientation:String! = "all"
@@ -429,12 +429,32 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
// MARK: - Prop setters
@objc
func setResizeMode(_ mode: String?) {
if _controls {
_playerViewController?.videoGravity = AVLayerVideoGravity(rawValue: mode ?? "")
} else {
_playerLayer?.videoGravity = AVLayerVideoGravity(rawValue: mode ?? "")
func setResizeMode(_ mode: String) {
var resizeMode: AVLayerVideoGravity = .resizeAspect
switch mode {
case "contain":
resizeMode = .resizeAspect
break
case "none":
resizeMode = .resizeAspect
break
case "cover":
resizeMode = .resizeAspectFill
break
case "stretch":
resizeMode = .resize
break
default:
resizeMode = .resizeAspect
}
if _controls {
_playerViewController?.videoGravity = resizeMode
} else {
_playerLayer?.videoGravity = resizeMode
}
_resizeMode = mode
}

9
ios/Video/RCTVideoManager.swift
View File

@@ -84,15 +84,6 @@ class RCTVideoManager: RCTViewManager {
})
}
override func constantsToExport() -> [AnyHashable : Any]? {
return [
"ScaleNone": AVLayerVideoGravity.resizeAspect,
"ScaleToFill": AVLayerVideoGravity.resize,
"ScaleAspectFit": AVLayerVideoGravity.resizeAspect,
"ScaleAspectFill": AVLayerVideoGravity.resizeAspectFill
]
}
override class func requiresMainQueueSetup() -> Bool {
return true
}