railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

little improvement over too many "def"

Browse Source 
just added a function which acts like a ternary with fallback option. Hence, less cluttered "def" variables
great to see that lib is supporting already SDK 27
This commit is contained in:
Danish 2018-07-24 17:36:24 +03:00 committed by GitHub
parent 46d0bc88b7
commit 6c946d77f3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
android/build.gradle
View File

@ -1,20 +1,16 @@
apply plugin: 'com.android.library' apply plugin: 'com.android.library'
def _ext = rootProject.ext def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
def _reactNativeVersion = _ext.has('reactNative') ? _ext.reactNative : '+' }
def _compileSdkVersion = _ext.has('compileSdkVersion') ? _ext.compileSdkVersion : 27
def _buildToolsVersion = _ext.has('buildToolsVersion') ? _ext.buildToolsVersion : '27.0.3'
def _minSdkVersion = _ext.has('minSdkVersion') ? _ext.minSdkVersion : 16
def _targetSdkVersion = _ext.has('targetSdkVersion') ? _ext.targetSdkVersion : 27
android { android {
compileSdkVersion _compileSdkVersion compileSdkVersion safeExtGet('compileSdkVersion', 27)
buildToolsVersion _buildToolsVersion buildToolsVersion safeExtGet('buildToolsVersion', '27.0.3')
defaultConfig { defaultConfig {
minSdkVersion _minSdkVersion minSdkVersion safeExtGet('minSdkVersion', 16)
targetSdkVersion _targetSdkVersion targetSdkVersion safeExtGet('targetSdkVersion', 27)
versionCode 1 versionCode 1
versionName "1.0" versionName "1.0"
ndk { ndk {
@ -25,6 +21,6 @@ android {
dependencies { dependencies {
//noinspection GradleDynamicVersion //noinspection GradleDynamicVersion
provided "com.facebook.react:react-native:${_reactNativeVersion}" provided "com.facebook.react:react-native:${safeExtGet('reactNativeVersion', '+')}"
compile 'com.yqritc:android-scalablevideoview:1.0.4' compile 'com.yqritc:android-scalablevideoview:1.0.4'
} }