railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #800 from tablexi/allow-progress-update-interval-to-work-on-ios

Browse Source 
Allow setting progressUpdateInterval to work on iOS
This commit is contained in:
Hampton Maxwell 2018-05-29 16:11:44 -07:00 committed by GitHub
commit 6c139a7821
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
ios/RCTVideo.m
View File

@ -124,15 +124,16 @@ static NSString *const timedMetadata = @"timedMetadata";
return (kCMTimeRangeZero); return (kCMTimeRangeZero);
} }
- (void)addPlayerTimeObserver -(void)addPlayerTimeObserver
{ {
const Float64 progressUpdateIntervalMS = _progressUpdateInterval / 1000; const Float64 progressUpdateIntervalMS = _progressUpdateInterval / 1000;
// @see endScrubbing in AVPlayerDemoPlaybackViewController.m of https://developer.apple.com/library/ios/samplecode/AVPlayerDemo/Introduction/Intro.html // @see endScrubbing in AVPlayerDemoPlaybackViewController.m
__weak RCTVideo *weakSelf = self; // of https://developer.apple.com/library/ios/samplecode/AVPlayerDemo/Introduction/Intro.html
_timeObserver = [_player addPeriodicTimeObserverForInterval:CMTimeMakeWithSeconds(progressUpdateIntervalMS, NSEC_PER_SEC) __weak RCTVideo *weakSelf = self;
queue:NULL _timeObserver = [_player addPeriodicTimeObserverForInterval:CMTimeMakeWithSeconds(progressUpdateIntervalMS, NSEC_PER_SEC)
usingBlock:^(CMTime time) { [weakSelf sendProgressUpdate]; } queue:NULL
]; usingBlock:^(CMTime time) { [weakSelf sendProgressUpdate]; }
];
} }
/* Cancels the previously registered time observer. */ /* Cancels the previously registered time observer. */
@ -738,6 +739,11 @@ static NSString *const timedMetadata = @"timedMetadata";
- (void)setProgressUpdateInterval:(float)progressUpdateInterval - (void)setProgressUpdateInterval:(float)progressUpdateInterval
{ {
_progressUpdateInterval = progressUpdateInterval; _progressUpdateInterval = progressUpdateInterval;
if (_timeObserver) {
[self removePlayerTimeObserver];
[self addPlayerTimeObserver];
}
} }
- (void)removePlayerLayer - (void)removePlayerLayer