From aaa961296b3d735ffaa0be480703a395b8de383d Mon Sep 17 00:00:00 2001 From: Sunbreak Date: Thu, 9 Mar 2023 16:41:11 +0800 Subject: [PATCH 1/5] fix: remove dummy nativeOnly --- Video.js | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/Video.js b/Video.js index 808c0a51..dc451d3e 100644 --- a/Video.js +++ b/Video.js @@ -416,13 +416,6 @@ Video.propTypes = { FilterType.SEPIA, ]), filterEnabled: PropTypes.bool, - /* Native only */ - src: PropTypes.object, - seek: PropTypes.oneOfType([ - PropTypes.number, - PropTypes.object, - ]), - fullscreen: PropTypes.bool, onVideoLoadStart: PropTypes.func, onVideoLoad: PropTypes.func, onVideoBuffer: PropTypes.func, @@ -566,10 +559,4 @@ Video.propTypes = { ...ViewPropTypes, }; -const RCTVideo = requireNativeComponent('RCTVideo', Video, { - nativeOnly: { - src: true, - seek: true, - fullscreen: true, - }, -}); +const RCTVideo = requireNativeComponent('RCTVideo'); From 7f3d707628fc4cfa1bb5de8ac616f1d23a4961a7 Mon Sep 17 00:00:00 2001 From: Roland Yeghiazaryan Date: Thu, 15 Jun 2023 10:56:37 +0200 Subject: [PATCH 2/5] Fix ids in exo_player_control_view --- .../res/layout/exo_player_control_view.xml | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/android/src/main/res/layout/exo_player_control_view.xml b/android/src/main/res/layout/exo_player_control_view.xml index 19440912..27d3883e 100644 --- a/android/src/main/res/layout/exo_player_control_view.xml +++ b/android/src/main/res/layout/exo_player_control_view.xml @@ -14,27 +14,27 @@ android:paddingTop="4dp" android:orientation="horizontal"> - - - - - - @@ -46,7 +46,7 @@ android:gravity="center_vertical" android:orientation="horizontal"> - - Date: Mon, 3 Jul 2023 22:12:44 +0200 Subject: [PATCH 3/5] feat: RN 0.73 support Adds `namespace` prop which is required by Gradle 8 (dep. of RN 0.73) --- android/build.gradle | 1 + 1 file changed, 1 insertion(+) diff --git a/android/build.gradle b/android/build.gradle index 0c3969c9..de702f92 100644 --- a/android/build.gradle +++ b/android/build.gradle @@ -17,6 +17,7 @@ def configStringPath = ( ).md5() android { + namespace 'com.brentvatne.react' compileSdkVersion safeExtGet('compileSdkVersion', 31) buildToolsVersion safeExtGet('buildToolsVersion', '30.0.2') From 8723114403358f05988b78129406463cf4309adf Mon Sep 17 00:00:00 2001 From: Olivier Bouillet <62574056+freeboub@users.noreply.github.com> Date: Sat, 8 Jul 2023 21:50:20 +0200 Subject: [PATCH 4/5] Update issue templates --- .github/ISSUE_TEMPLATE/bug_report.md | 29 ++++++++-------------------- 1 file changed, 8 insertions(+), 21 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 223be5ae..61d5de71 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -10,37 +10,24 @@ assignees: '' # Bug ## Platform - Which player are you experiencing the problem on: * iOS * Android -* Windows UWP -* Windows WPF +* Windows ## Environment info - - -React native info output: - -```bash - // paste it here -``` - + Library version: x.x.x +Device: ## Steps To Reproduce From c23bcddc9b898980ff085f22d36bd0872965605f Mon Sep 17 00:00:00 2001 From: olivier Date: Sat, 8 Jul 2023 23:20:09 +0200 Subject: [PATCH 5/5] chore: fix build issue --- ios/Video/RCTVideo-Bridging-Header.h | 1 + 1 file changed, 1 insertion(+) diff --git a/ios/Video/RCTVideo-Bridging-Header.h b/ios/Video/RCTVideo-Bridging-Header.h index 77815e4e..586eec11 100644 --- a/ios/Video/RCTVideo-Bridging-Header.h +++ b/ios/Video/RCTVideo-Bridging-Header.h @@ -1,5 +1,6 @@ #import #import "RCTVideoSwiftLog.h" +#import "RCTEventDispatcher.h" #if __has_include() #import "RCTVideoCache.h"