railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix attachListeners method's threading issue & other notification handling issues

Browse Source
This commit is contained in:
Baris Sencan 2015-06-24 19:09:05 -07:00 committed by Brent Vatne
parent 17595f975b
commit 44b17119dd
1 changed files with 11 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
RCTVideo.m
View File

@ -120,13 +120,6 @@ static NSString *const statusKeyPath = @"status";
[_progressUpdateTimer addToRunLoop:[NSRunLoop mainRunLoop] forMode:NSDefaultRunLoopMode]; [_progressUpdateTimer addToRunLoop:[NSRunLoop mainRunLoop] forMode:NSDefaultRunLoopMode];
} }
- (void)notifyEnd:(NSNotification *)notification
{
[_eventDispatcher sendInputEventWithName:RNVideoEventEnd body:@{
@"target": self.reactTag
}];
}
- (void)addPlayerItemObserver - (void)addPlayerItemObserver
{ {
[_playerItem addObserver:self forKeyPath:statusKeyPath options:0 context:nil]; [_playerItem addObserver:self forKeyPath:statusKeyPath options:0 context:nil];
@ -237,19 +230,25 @@ static NSString *const statusKeyPath = @"status";
- (void)attachListeners - (void)attachListeners
{ {
dispatch_async(dispatch_get_main_queue(), ^{
// listen for end of file // listen for end of file
[[NSNotificationCenter defaultCenter] addObserver:self [[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(notifyEnd:) selector:@selector(playerItemDidEnd:)
name:AVPlayerItemDidPlayToEndTimeNotification name:AVPlayerItemDidPlayToEndTimeNotification
object:[_player currentItem]]; object:[_player currentItem]];
});
} }
- (void)playerItemDidReachEnd:(NSNotification *)notification - (void)playerItemDidEnd:(NSNotification *)notification
{ {
[_eventDispatcher sendInputEventWithName:RNVideoEventEnd body:@{
@"target": self.reactTag
}];
if (_repeat) {
AVPlayerItem *item = [notification object]; AVPlayerItem *item = [notification object];
[item seekToTime:kCMTimeZero]; [item seekToTime:kCMTimeZero];
[self applyModifiers]; [self applyModifiers];
}
} }
#pragma mark - Prop setters #pragma mark - Prop setters
@ -342,27 +341,8 @@ static NSString *const statusKeyPath = @"status";
[self setPaused:_paused]; [self setPaused:_paused];
} }
- (void)setRepeatEnabled
{
[[NSNotificationCenter defaultCenter] addObserver:self
selector:@selector(playerItemDidReachEnd:)
name:AVPlayerItemDidPlayToEndTimeNotification
object:[_player currentItem]];
}
- (void)setRepeatDisabled
{
[[NSNotificationCenter defaultCenter] removeObserver:self];
}
- (void)setRepeat:(BOOL)repeat { - (void)setRepeat:(BOOL)repeat {
_repeat = repeat; _repeat = repeat;
if (repeat) {
[self setRepeatEnabled];
} else {
[self setRepeatDisabled];
}
} }
#pragma mark - React View Management #pragma mark - React View Management