Code formatting cleanups for controls

This commit is contained in:
Hampton Maxwell 2019-02-10 18:15:30 -08:00 committed by GitHub
parent c361b795fc
commit 40803496f9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -267,7 +267,7 @@ class ReactExoplayerView extends FrameLayout implements
*/ */
private void togglePlayerControlVisibility() { private void togglePlayerControlVisibility() {
reLayout(playerControlView); reLayout(playerControlView);
if(playerControlView.isVisible()) { if (playerControlView.isVisible()) {
playerControlView.hide(); playerControlView.hide();
} else { } else {
playerControlView.show(); playerControlView.show();
@ -278,16 +278,16 @@ class ReactExoplayerView extends FrameLayout implements
* Initializing Player control * Initializing Player control
*/ */
private void initializePlayerControl() { private void initializePlayerControl() {
if(playerControlView == null) { if (playerControlView == null) {
playerControlView = new PlayerControlView(getContext()); playerControlView = new PlayerControlView(getContext());
} }
//Setting the player for the playerControlView // Setting the player for the playerControlView
playerControlView.setPlayer(player); playerControlView.setPlayer(player);
playerControlView.show(); playerControlView.show();
playPauseControlContainer = playerControlView.findViewById(R.id.exo_play_pause_container); playPauseControlContainer = playerControlView.findViewById(R.id.exo_play_pause_container);
//Invoking onClick event for exoplayerView // Invoking onClick event for exoplayerView
exoPlayerView.setOnClickListener(new OnClickListener() { exoPlayerView.setOnClickListener(new OnClickListener() {
@Override @Override
public void onClick(View v) { public void onClick(View v) {
@ -295,7 +295,7 @@ class ReactExoplayerView extends FrameLayout implements
} }
}); });
//Invoking onPlayerStateChanged event for Player // Invoking onPlayerStateChanged event for Player
eventListener = new Player.EventListener() { eventListener = new Player.EventListener() {
@Override @Override
public void onPlayerStateChanged(boolean playWhenReady, int playbackState) { public void onPlayerStateChanged(boolean playWhenReady, int playbackState) {
@ -320,12 +320,12 @@ class ReactExoplayerView extends FrameLayout implements
/** /**
* Update the layout * Update the layout
* @param view view needs to update layout
* *
* This is a workaround for the open bug in react-native: https://github.com/facebook/react-native/issues/17968 * This is a workaround for the open bug in react-native: https://github.com/facebook/react-native/issues/17968
* @param view view needs to update layout
*/ */
private void reLayout(View view) { private void reLayout(View view) {
if(view == null) return; if (view == null) return;
view.measure(MeasureSpec.makeMeasureSpec(getMeasuredWidth(), MeasureSpec.EXACTLY), view.measure(MeasureSpec.makeMeasureSpec(getMeasuredWidth(), MeasureSpec.EXACTLY),
MeasureSpec.makeMeasureSpec(getMeasuredHeight(), MeasureSpec.EXACTLY)); MeasureSpec.makeMeasureSpec(getMeasuredHeight(), MeasureSpec.EXACTLY));
view.layout(view.getLeft(), view.getTop(), view.getMeasuredWidth(), view.getMeasuredHeight()); view.layout(view.getLeft(), view.getTop(), view.getMeasuredWidth(), view.getMeasuredHeight());
@ -377,7 +377,7 @@ class ReactExoplayerView extends FrameLayout implements
loadVideoStarted = true; loadVideoStarted = true;
} }
//Initializing the playerControlView // Initializing the playerControlView
initializePlayerControl(); initializePlayerControl();
} }
@ -1141,16 +1141,13 @@ class ReactExoplayerView extends FrameLayout implements
/** /**
* Handling controls prop * Handling controls prop
* *
* @param controls value of the controls prop passed from react-native * @param controls Controls prop, if true enable controls, if false disable them
*/ */
public void setControls(boolean controls) { public void setControls(boolean controls) {
if(controls && (exoPlayerView != null)) { if (controls && exoPlayerView != null) {
//adding the playerControlView addPlayerControl();
addPlayerControl(); } else if (getChildAt(1) instanceof PlayerControlView && exoPlayerView != null) {
} else { removeViewAt(1);
if(getChildAt(1) instanceof PlayerControlView && (exoPlayerView != null)){
removeViewAt(1);
}
} }
} }
} }