railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert crash fix when removing player layer observer

Browse Source 
Couldn't figure out how this was happening, so I don't want to hide it with try/catch. Let's get it fixed instead.
This commit is contained in:
Hampton Maxwell 2018-09-03 18:30:19 -07:00 committed by GitHub
parent 80b71b1922
commit 3d40935cc1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ios/RCTVideo.m
View File

@ -732,10 +732,7 @@ static NSString *const timedMetadata = @"timedMetadata";
- (void)removePlayerLayer - (void)removePlayerLayer
{ {
[_playerLayer removeFromSuperlayer]; [_playerLayer removeFromSuperlayer];
@try{
[_playerLayer removeObserver:self forKeyPath:readyForDisplayKeyPath]; [_playerLayer removeObserver:self forKeyPath:readyForDisplayKeyPath];
}@catch (NSException * e) {
}
_playerLayer = nil; _playerLayer = nil;
} }
@ -826,10 +823,7 @@ static NSString *const timedMetadata = @"timedMetadata";
{ {
[_player pause]; [_player pause];
if (_playbackRateObserverRegistered) { if (_playbackRateObserverRegistered) {
@try{
[_player removeObserver:self forKeyPath:playbackRate context:nil]; [_player removeObserver:self forKeyPath:playbackRate context:nil];
}@catch (NSException * e) {
}
_playbackRateObserverRegistered = NO; _playbackRateObserverRegistered = NO;
} }
_player = nil; _player = nil;