railbird/react-native-video
9
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #2609 from tironiigor/always-check-for-hideShutterView

Browse Source 
Always check for hideShutterView before showing shutterView
This commit is contained in:
Eran Hammer 2022-05-02 12:58:49 -07:00 committed by GitHub
commit 0dbdb7ae71
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -13,6 +13,7 @@
- Fix nil string uri parameter error [#695](https://github.com/react-native-video/react-native-video/pull/695) - Fix nil string uri parameter error [#695](https://github.com/react-native-video/react-native-video/pull/695)
- (Breaking) Bump shaka-player to 3.3.2 [#2587](https://github.com/react-native-video/react-native-video/pull/2587) - (Breaking) Bump shaka-player to 3.3.2 [#2587](https://github.com/react-native-video/react-native-video/pull/2587)
- Improve basic player example on android [#2662](https://github.com/react-native-video/react-native-video/pull/2662) - Improve basic player example on android [#2662](https://github.com/react-native-video/react-native-video/pull/2662)
- Ensure we always use `hideShutterView` before showing the `shutterView` on Android [#2609](https://github.com/react-native-video/react-native-video/pull/2609)
### Version 5.2.0 ### Version 5.2.0

4
android-exoplayer/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java
View File

@ -136,7 +136,7 @@ public final class ExoPlayerView extends FrameLayout {
clearVideoView(); clearVideoView();
} }
this.player = player; this.player = player;
shutterView.setVisibility(VISIBLE); shutterView.setVisibility(this.hideShutterView ? View.INVISIBLE : View.VISIBLE);
if (player != null) { if (player != null) {
setVideoView(); setVideoView();
player.addVideoListener(componentListener); player.addVideoListener(componentListener);
@ -203,7 +203,7 @@ public final class ExoPlayerView extends FrameLayout {
} }
} }
// Video disabled so the shutter must be closed. // Video disabled so the shutter must be closed.
shutterView.setVisibility(VISIBLE); shutterView.setVisibility(this.hideShutterView ? View.INVISIBLE : View.VISIBLE);
} }
public void invalidateAspectRatio() { public void invalidateAspectRatio() {